(Feature) Apply new design to step 6: "Contribute"

gabitoesmiapodo commented 5 years ago

Closes #1090

Description:

New styles for the Contribute section.

Changed the circle component for one more adequate to the desired results.

And @mariano-aguero fixed the erratic behavior of the backwards ticking circle / clock.

Screenshots:

localhost_3000_1 laptop with mdpi screen localhost_3000_1 ipad localhost_3000_contribute_addr 0x856be5c59dcf928cbe0cbcc70534090b21420646 networkid 3 ipad

BlackDuckCoPilot commented 5 years ago

Black Duck Security Report

Merging #1230 into integration/#1082-new-design will not change security risk.

Added Components

Clean: 1

Removed Components

Clean: 4

Click here to see full report

dennis00010011b commented 5 years ago

@gabitoesmiapodo

Should be 'proxy address' instead 'Execution ID'
Should be icon copy for current account

dennis00010011b commented 5 years ago

@gabitoesmiapodo Ticker always should be in capital letters even if user has entered it in lower case on Step 2

dennis00010011b commented 5 years ago

@gabitoesmiapodo Contribute with QR code

Change text Send ethers to the Auth-os Proxy smart-contract address with a MethodID: to Send ethers to the crowdsale proxy address with a data:
Add copy icon for data

3.There isn't warning Think twice before contributing to Crowdsales. Tokens will be deposited on a wallet you used to buy tokens. It only for 'Wallet ' option now, not for QR

dennis00010011b commented 5 years ago

@gabitoesmiapodo

Word 'Crowdsales' starts from capital letter, should be lower case
Contribution's dimension should be Tokens , not Token

dennis00010011b commented 5 years ago

@gabitoesmiapodo Text size of text 'Contribute page ' less than others

dennis00010011b commented 5 years ago

@gabitoesmiapodo Total amount of tiers is incorrect Steps:

Create minted crowdsale with 2 tiers
Wait until 1 tiers is finished
Contribute any amount in tier 2

dennis00010011b commented 5 years ago

@gabitoesmiapodo Error message overlapped

mariano-aguero commented 5 years ago

Hi @dennis00010011b

Total amount of tiers is incorrect Steps: Create minted crowdsale with 2 tiers Wait until 1 tiers is finished Contribute any amount in tier 2

I try to reproduce the problem without success, Did you update the branch?

Here is some videos: https://www.useloom.com/share/9f8b4c1359dd46fa8f39ca74262d0062

https://www.useloom.com/share/4988223db77243b282452b01703ea6f8

Do you see something that I'm missing?

Due to the use of localStorage you should only have one crowdsale open in the browser.

Thanks

dennis00010011b commented 5 years ago

@gabitoesmiapodo In the dutch case the balance goes beyond of block's border Would be better to round to 3rd decimal? For all token'

s values on the page

gabitoesmiapodo commented 5 years ago

@dennis00010011b

Should be 'proxy address' instead 'Execution ID' -> Changed it.
Should be icon copy for current account -> Added.
Ticker always should be in capital letters even if user has entered it in lower case on Step 2 -> Fixed.
Change text Send ethers to the Auth-os Proxy smart-contract address with a MethodID: to Send ethers to the crowdsale proxy address with a data: -> Changed it.
Add copy icon for data -> Added it.
There isn't warning Think twice before contributing to Crowdsales. Tokens will be deposited on a wallet you used to buy tokens. It only for 'Wallet ' option now, not for QR -> Fixed, it's always on now.
Word 'Crowdsales' starts from capital letter, should be lower case -> Fixed it.
Contribution's dimension should be Tokens , not Token -> Fixed it.
Text size of text 'Contribute page ' less than others -> That's in the design: https://zpl.io/bJqgnXx Not sure if it's a mistake or not, or why it's like that.
Total amount of tiers is incorrect -> @mariano-aguero will address that.
Error message overlapped -> Fixed.
In the dutch case the balance goes beyond of block's border. Would be better to round to 3rd decimal? For all token' -> Not sure about rounding the numbers, but token values should wrap now.

dennis00010011b commented 5 years ago

@gabitoesmiapodo Button 'Contribute' doesn't look like disabled when it is really disabled (isn't allowed to buy) Needs make it in gray color or use special mouse cursor

dennis00010011b commented 5 years ago

@gabitoesmiapodo timer is displayed if crowdsale has been finalized Should be text only : ' crowdsale has been finalized'

dennis00010011b commented 5 years ago

@gabitoesmiapodo @mariano-aguero Minted, 2 tiers: investor can't buy in second tier if already has bough total supply in 1st tier Steps:

Create Minted crowdsale,2 tiers, no whitelist, mincaps = 0
Buy full supply for tier 1
Wait until 2nd tier starts
Try to buy from the same account

Expected result:

investor should be allowed to buy in 2nd tier

Actual result:

investor can't buy
fields 'min/max contribution' have value = 'you are not allowed'

This issue isn't reproducible in branch 2.0

mariano-aguero commented 5 years ago

@dennis00010011b

timer is displayed if crowdsale has been finalized Should be text only : ' crowdsale has been finalized'

Should be fixed

gabitoesmiapodo commented 5 years ago

@dennis00010011b

Button 'Contribute' doesn't look like disabled when it is really disabled (isn't allowed to buy) Needs make it in gray color or use special mouse cursor -> Button's style is the same that's being used all around the DApp (it's shared). It looks good to me, and I think it should be consistent with everything else in the design.

I added the "not-allowed" cursor as suggested, anyway.

dennis00010011b commented 5 years ago

@gabitoesmiapodo @mariano-aguero Everything looks good except https://github.com/poanetwork/token-wizard/pull/1230#issuecomment-441829978

mariano-aguero commented 5 years ago

@dennis00010011b

Everything looks good except #1230 (comment)

I'm working on this, I see an issue created for this #1235 The rest LGTM

Regards

mariano-aguero commented 5 years ago

@dennis00010011b

Minted, 2 tiers: investor can't buy in second tier if already has bough total supply in 1st tier Steps:

Create Minted crowdsale,2 tiers, no whitelist, mincaps = 0 Buy full supply for tier 1 Wait until 2nd tier starts Try to buy from the same account Expected result:

investor should be allowed to buy in 2nd tier Actual result:

investor can't buy fields 'min/max contribution' have value = 'you are not allowed' This issue isn't reproducible in branch 2.0

There is a bug in the method getCurrentTierInfo of the contracts.They can not be modified because they have already been audited. I fixed with a 'retry' approach, so you will see a "Waiting ..." label until the data is as expected. The button 'Contribute'' will be enabled when the data is completely propagated in the blockchain.

If the fix is OK, I think this issue #1235 must be closed.

Regards

dennis00010011b commented 5 years ago

@mariano-aguero @gabitoesmiapodo After tier has been sold the timer's count is still displayed if switches account in NW https://www.useloom.com/share/a9333be153d04a37aee18994372b2687

dennis00010011b commented 5 years ago

Time format should be hh:mm ,ex. 00:09, not0:9

mariano-aguero commented 5 years ago

@dennis00010011b

Time format should be hh:mm ,ex. 00:09, not0:9

Fixed

mariano-aguero commented 5 years ago

@dennis00010011b

@mariano-aguero @gabitoesmiapodo After tier has been sold the timer's count is still displayed if switches account in NW

https://www.useloom.com/share/a9333be153d04a37aee18994372b2687

Fixed

mariano-aguero commented 5 years ago

@dennis00010011b

Remember to close this issue #1235 if is all OK

Regards

dennis00010011b commented 5 years ago

@dennis00010011b

@mariano-aguero @gabitoesmiapodo After tier has been sold the timer's count is still displayed if switches account in NW

Fixed

Clock isn't displayed now but there is should be text: "crowdsale has ended"

dennis00010011b commented 5 years ago

@mariano-aguero @gabitoesmiapodo Incorrect error message if enter incorrect value before start of crowdsale . Should be You are not allowed

mariano-aguero commented 5 years ago

@dennis00010011b

Clock isn't displayed now but there is should be text: "crowdsale has ended"

Incorrect error message if enter incorrect value before start of crowdsale . Should be You are not allowed

Done

gabitoesmiapodo commented 5 years ago

@dennis00010011b

Since development of TW is halting for now (see https://medium.com/poa-network/farewell-token-wizard-2-0-time-to-reprioritize-8cbd7319a97b), I think we need to keep this issue / PR exclusively for the rebranding / visual style related work.

Please create separate issues for any new business logic related problems you may find, as these problems still exist and we or anyone else might fix them in the future.

If there aren't any more visual problems and we have your approval for this PR we will proceed to merge it and finish this part of the job.

dennis00010011b commented 5 years ago

@mariano-aguero

Incorrect error message if enter incorrect value before start of crowdsale . Should be You are not allowed

Done

There is error message If correct value is entered before start. Shouldn't be any error message in such case, button 'Contribute' should be enabled, should be popup '"Wait, please. Crowdsale company hasn't started yet. It'll start from....'

mariano-aguero commented 5 years ago

@dennis00010011b

@mariano-aguero

Incorrect error message if enter incorrect value before start of crowdsale . Should be You are not allowed

Done

There is error message If correct value is entered before start. Shouldn't be any error message in such case, button 'Contribute' should be enabled, should be popup '"Wait, please. Crowdsale company hasn't started yet. It'll start from....'

Updated the behaviour

poanetwork / token-wizard