poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Bug) Dutch -Step3: allowed to add whitelist if the supply field is empty #1234

Closed mariano-aguero closed 5 years ago

mariano-aguero commented 5 years ago

Closes #1233

mariano-aguero commented 5 years ago

@dennis00010011b

Check if this issue #1183 is reproducible in this branch.

If this is solved, I think we should close that issue. The design branch will replace the branch 2.0 in the next days and it is not worth the effort to solve it in the branch 2.0

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 3588


Totals Coverage Status
Change from base Build 3576: 0.08%
Covered Lines: 1693
Relevant Lines: 4781

💛 - Coveralls
dennis00010011b commented 5 years ago

@mariano-aguero Still possible to add whitelist without supply Steps:

  1. Go to Step3
  2. Fill out Supply
  3. Enable whitelist
  4. Clear Supply
  5. Add whitelist

    Expected result:

    • if supply empty then whitelist container should disappear and whitelist enabled flag should be No (see how it works for Minted startegy)
screen shot 2018-11-26 at 08 28 42
mariano-aguero commented 5 years ago

Still possible to add whitelist without supply Steps:

  • Go to Step3
  • Fill out Supply
  • Enable whitelist
  • Clear Supply
  • Add whitelist

Expected result: if supply empty then whitelist container should disappear and whitelist enabled flag should be No (see how it works for Minted startegy)

@dennis00010011b Ok, thats another scenario. Fixed in the previous commit

Thanks

dennis00010011b commented 5 years ago

@mariano-aguero Possible to add whitelist if tier's supply more than total supply and error warning is displayed

screen shot 2018-11-26 at 09 33 24
mariano-aguero commented 5 years ago

@dennis00010011b

Possible to add whitelist if tier's supply more than total supply and error warning is displayed

Fixed