search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Fix) Disable save button if there is no changes #915

Closed vbaranov closed 6 years ago

vbaranov commented 6 years ago

Closes https://github.com/poanetwork/token-wizard/issues/903

Save button doesn't make any actions now if no updates of tiers duration or whitelists.

dennis00010011b commented 6 years ago

Crowdsale parameters { "name": "scenarioE2eMintedWhitelist", "ticker": "test", "decimals": 18, "reservedTokens":[ { "address" :"0xecDFec71AbCD5a612eAf9169B19E907eAA2717d9", "dimension": "percentage", "value": 250 }, { "address" : "0x56B2e3C3cFf7f3921Dc2e0F8B8e20d1eEc29216b", "dimension": "tokens", "value":100000000 } ], "walletAddress":"0x56B2e3C3cFf7f3921Dc2e0F8B8e20d1eEc29216b", "gasprice": 1, "mincap": 1,

"tiers":[ { "name":"###1", "allowModify": true, "isWhitelisted":true, "startDate": "1600000", "startTime": "16600000", "endDate":"23/02/2050", "endTime":"12:34", "rate":20000, "supply": 250, "whitelist":[ { "address": "0xF16AB2EA0a7F7B28C267cbA3Ed211Ea5c6e27411", "min": 50, "max": 150 }, { "address": "0x9E963042D581D262AdE4E31541360e7FDAeE70C6", "min": 50, "max": 150 } ] }, { "name":"###2", "allowModify": true, "isWhitelisted":true, "startDate": "", "startTime": "", "endDate":"", "endTime":"", "rate":10000, "supply": 200, "whitelist":[ { "address": "0xdDdC96314b7f16cB243Cb07e1dE081CA367095E7", "min": 25, "max": 250 } ] } ] }

Steps:

  1. Create crowdsale
  2. Open manage page as an owner
  3. Change end time of 1 tier for 5 minute later than start time.
  4. Submit two transaction

Exec ID: 0x7193beb3acd157734871e1c53d15497167af16b8ee9c9996581a58444503c3a3 Ropsten

dennis00010011b commented 6 years ago

Also, one more issue: only 1 whitelist address is rendered to manage page for each tier

coveralls commented 6 years ago

Pull Request Test Coverage Report for Build 2236

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/manage/index.js 0 28 0.0%
<!-- Total: 2 30 6.67% -->
Files with Coverage Reduction New Missed Lines %
src/components/manage/utils.js 2 13.62%
src/components/manage/index.js 2 0.0%
<!-- Total: 4 -->
Totals Coverage Status
Change from base Build 2234: 0.005%
Covered Lines: 745
Relevant Lines: 3254
💛 - Coveralls
vbaranov commented 6 years ago

@dennis00010011b let's create separate issues for what you mentioned. Does disabling of "Save" button work correct?

dennis00010011b commented 6 years ago

@vbaranov Button 'Save' works without issues

https://github.com/poanetwork/token-wizard/issues/919