search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
386 stars 215 forks source link

(Fix) Allow min cap edit after crowdsale started #954

Closed fernandomg closed 6 years ago

fernandomg commented 6 years ago

Closes #948

dennis00010011b commented 6 years ago

@fernandomg minCap field is modifiable after crowdsale time expired. Should be disabled

screen shot 2018-06-12 at 08 25 46
fernandomg commented 6 years ago

will it be enabled, if crowdsale is not modifiable? It should because changing of whitelists and global min cap doesn't depend on isModifiable flag

ok, just added that condition

dennis00010011b commented 6 years ago

@fernandomg Button 'Save' isn't rendered on manage page if allowModify disabled. Field minCap enabled but user can't change it anyway

screen shot 2018-06-12 at 17 16 00
fernandomg commented 6 years ago

Ok, I refactored a bit the manage page startup flow. Now flags used to validate editing are centralized and more explicit. Hope this helps avoid undesired outcomes.

@dennis00010011b @vbaranov

dennis00010011b commented 6 years ago

@fernandomg disabled to contribute new minCap value. Field 'Contribute' is validated with old minCap Ropsten, Exec ID 0x994a4b4eddb300691ee19901712848b1114bad8a1a4ae195e5abe0ec38021b94

screen shot 2018-06-13 at 15 27 14 screen shot 2018-06-13 at 15 31 51
fernandomg commented 6 years ago

@dennis00010011b I don't think this is a bug related to the manage screen, as you're able to see the value has properly changed.

Despite that, I tried to reproduce it but with no luck. MinCap is updated properly in the invest page.

Please check: 0xf0d642dbc7517672e217238a2f008f4f8cdad0586d8ce5113e9e09dcc6860619