search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
384 stars 215 forks source link

(Feature) deployment step: global min cap per tier #968

Closed vbaranov closed 6 years ago

vbaranov commented 6 years ago

Closes https://github.com/poanetwork/token-wizard/issues/962

screencapture-localhost-3000-3-2018-06-19-17_05_45

fernandomg commented 6 years ago

For the 2nd tier. If I enable whiteliste, Continue button remains disabled. It's checking minCap validity:

image

fernandomg commented 6 years ago

Also, if 1st tier minCap has a value, after enabling whitelist for the second tier... first tier minCap is set to 0 (zero)

dennis00010011b commented 6 years ago

Field minCap is always empty. Possible cause could be that getCurrentTierInfo().tier_min returns value in tokens, not in wei.

Parameters: 1 tier, minCap, no whitelist, not modifiable. I used lastest .env https://github.com/poanetwork/token-wizard/blob/874209ae06233b4c1de4b54c44717ca557795013/.env.example#L1

screen shot 2018-06-19 at 10 59 21
dennis00010011b commented 6 years ago

Manage page: whitelist container presents if duration_is_modifiable = true, whitelist_enabled = false Parameters: 1 tier, minCap, no whitelist, modifiable. I used lastest .env https://github.com/poanetwork/token-wizard/blob/874209ae06233b4c1de4b54c44717ca557795013/.env.example#L1

screen shot 2018-06-19 at 11 31 48
vbaranov commented 6 years ago

@dennis00010011b the PR is for deployment step mainly. @fernandomg will continue changes for management page in frames of https://github.com/poanetwork/token-wizard/issues/961

vbaranov commented 6 years ago

@fernandomg fixed. Please take a look.

vbaranov commented 6 years ago

@dennis00010011b nevertheless I fixed this

Field minCap is always empty. Possible cause could be that getCurrentTierInfo().tier_min returns value in tokens, not in wei.

vbaranov commented 6 years ago

@dennis00010011b @fernandomg are there any issues except problems with management page? there are a lot of changes in this PR. Next PRs will depend on it. I suggest to adjust management page for new interface of Auth-os in a separate PR.

dennis00010011b commented 6 years ago

@vbaranov

  1. I can’t create multitier crowdsale. Transaction failed during deployment.
  2. minCap initialization incorrect: if mincap=12 on Step3 then minCap =12 in contracts and minCap =0,000000000000000012 tokens for investors
  3. minCap is not modifiable (related manage page but anyway)
dennis00010011b commented 6 years ago

@vbaranov

  1. If allowModify is enabled (duration_is_modifiable=true) then any address is not allowed to buy screen shot 2018-06-20 at 10 57 53
dennis00010011b commented 6 years ago

@vbaranov 1 .I created crowdsale with 2 tiers, 3 tiers were initializated . Extra tier is created.

  1. I still can't create crowdsale with 3 and more tiers. screen shot 2018-06-20 at 15 27 30

    Reverted transactions https://ropsten.etherscan.io/tx/0xdc540591c97bb7e1649266203cf80c6a781e04880cfa33cb44b329105b7b9738

https://ropsten.etherscan.io/tx/0x5f6cdc875c1517e079d4f057a3394a67eaa4fb32da24f41788bc26369caa5864

https://ropsten.etherscan.io/tx/0x3c96a1dea47e45117df1f960094f207b91b2e4aa8c94c9aca2b7a19bde814bed

https://ropsten.etherscan.io/tx/0x98f4ec93e595b51ff2d55d44237b3aaaeabf41906081c79691af5b3c55af07f0

ExecID 0x8d7046af0a7b8d23d3c71a45ddda222621610146f0c097aa2269420941e2d53e, Ropsten

vbaranov commented 6 years ago

@dennis00010011b

  1. I can’t create multitier crowdsale. Transaction failed during deployment.
  2. minCap initialization incorrect: if mincap=12 on Step3 then minCap =12 in contracts and minCap =0,000000000000000012 tokens for investors
  3. If allowModify is enabled (duration_is_modifiable=true) then any address is not allowed to buy

Fixed

1 .I created crowdsale with 2 tiers, 3 tiers were initializated . Extra tier is created.

Please post exec-id here.

  1. I still can't create crowdsale with 3 and more tiers.

I can't reproduce this. Is any error in Chrome dev console? Could you post the link to failed tx?

vbaranov commented 6 years ago

1 .I created crowdsale with 2 tiers, 3 tiers were initializated . Extra tier is created.

  1. I still can't create crowdsale with 3 and more tiers.

I reproduced both. It is not broken with this PR. These are issues with Auth-os.

vbaranov commented 6 years ago
  1. I created crowdsale with 2 tiers, 3 tiers were initializated . Extra tier is created.

This is also fixed. Function logic to add tiers was changed from Auth-os side.

  1. I still can't create crowdsale with 3 and more tiers.

It looks like a bug from Auth-os side.

I will merge this PR.