search

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI
MIT License
386 stars 215 forks source link

(Feature) Allow minCap modification from manage page #973

Closed fernandomg closed 6 years ago

fernandomg commented 6 years ago

Closes #961

Work for both Minted Capped and Dutch Auction strategies.

dennis00010011b commented 6 years ago

@fernandomg Issues that are not related minCap, MintedCapped:

  1. Incorrect value of maxCap for whitelisted. minCap is displayed instead
  2. button "Finalize " is active after finalization screen shot 2018-06-22 at 14 28 07
dennis00010011b commented 6 years ago

@fernandomg MintedCapped: minCap modification disabled after start of crowdsale. Should be enabled?

screen shot 2018-06-22 at 14 42 06
dennis00010011b commented 6 years ago

@fernandomg MintedCapped. Issue are not related minCap: end time isn't updatable, transaction isn't created

screen shot 2018-06-22 at 14 55 53
dennis00010011b commented 6 years ago

@fernandomg minCap field should be disabled if whitelist is enabled.

screen shot 2018-06-22 at 15 12 06
dennis00010011b commented 6 years ago

@fernandomg MintedCapped: Multitier crowdsale: 2nd tier's minCap should be modifiable.

screen shot 2018-06-22 at 15 41 56
dennis00010011b commented 6 years ago

@fernandomg DutchAuction: manage page should contain minRate, maxRate info

screen shot 2018-06-22 at 16 12 56
fernandomg commented 6 years ago

@dennis00010011b

Incorrect value of maxCap for whitelisted. minCap is displayed instead

reported as a new issue as it's not related to this PR changes: #974

button "Finalize " is active after finalization

reported as a new issue as it's not related to this PR changes: #975

MintedCapped: minCap modification disabled after start of crowdsale. Should be enabled?

No, it's stated in the MintedCappedCrowdsale README ConfigureSale.updateTierMinimum: ... The targeted tier must not be the current tier, or an already-passed tier.

MintedCapped. Issue are not related minCap: end time isn't updatable, transaction isn't created

Fixed

minCap field should be disabled if whitelist is enabled.

Fixed

MintedCapped: Multitier crowdsale: 2nd tier's minCap should be modifiable.

For that particular Crowdsale: 0x29af0939a5988989bfee913a9ad10b9335cb63ebc9fd2b69e5f877d0455ac919, that 2nd tier is not updatable, and it's required to allow minCap modification. https://github.com/auth-os/applications/blob/ffa14db66a0fde576b7bcef01124fd659dbed168/TokenWizard/crowdsale/MintedCappedCrowdsale/contracts/classes/sale_manager/features/ConfigureSale.sol#L222-L224

DutchAuction: manage page should contain minRate, maxRate info

reported as a new isssue as it's not related to this PR changes: #976

fernandomg commented 6 years ago

@dennis00010011b

mincap isn't modifiable for Dutch, transaction isn't created

thanks for that catch. Fixed

dennis00010011b commented 6 years ago

@fernandomg Dutch: minCap is modifiable even if tier has started 0x919fec4d504f9dbb32d914d1adcec3c99129a26000ad97ee049e0075bdd1a0cd, Ropsten

screen shot 2018-06-26 at 07 43 16
fernandomg commented 6 years ago

Dutch: minCap is modifiable even if tier has started

@dennis00010011b indeed. Auth-OS contract allow it. If this must behave as in Minted Capped strategy, then we should inform that.

@vbaranov ?

vbaranov commented 6 years ago

@fernandomg @dennis00010011b yes, it is correct, min cap is modifiable for ongoing crowdsale.