(Bug) Dutch: Finalization disabled if remainder of tokens less than minimum contribution - Githubissues

poanetwork / token-wizard

(Discontinued) TokenWizard is an DApp to create and manage crowdsale and token contracts using a simple UI

MIT License

384 stars 215 forks source link

(Bug) Dutch: Finalization disabled if remainder of tokens less than minimum contribution #984

Closed dennis00010011b closed 6 years ago

dennis00010011b commented 6 years ago

Related https://github.com/poanetwork/token-wizard/issues/929 Steps for reproduce:

Create Dutch crowdsale with parameters: - decimals=18, duration > 3days, minRate=10000, maxRate=100000, totalSupply=1000, tier's supply=1000
1. Buy as an owner 500 tokens
2. Buy as an investor 500 tokens.
3. Open manage page as an owner , observe button' Finalize'

Expected result:

owner should be able finalize if (supply< minimum contribution) because any future purshase impossible (since remainder of tokens less than minimum contribution and auth_os has the only condition for finalizing a Dutch sale is that (https://poanetwork.slack.com/archives/G9EBTJG9X/p1528470466000581) a. sender is admin b. crowdsale is initialized c. crowdsale is not already finalized )

Actual result:

owner is not able to finalize until crowdsale time over
- investors is not able to buy

If you are reporting a problem with Token Wizard, please include the following information:

Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)

0x54034dca961b61bc2a3147cc0c1986762915b42723ed64155364f17a2e296770 Ropsten

Do you have screenshots showing the problem?

screen shot 2018-06-26 at 15 33 23

Do you see errors in the dev console? If yes, please include a screenshot

No