search

poap-xyz / poap.js

POAP implemetation in javascript
https://sdk.poap.tech/
MIT License
9 stars 8 forks source link

feat: Exclude minted drop email reservations in total count #132

Closed reobin closed 3 months ago

reobin commented 3 months ago

The email reservation count for a drop includes reservations that have been minted already, and therefore skews the total collectors count in place where you want to do: mint count + reservation count = total collectors count.

A possibility is to keep both counts (minted and reserved), and choose which is preferred on each client. Worth discussing if we think that's needed.

netlify[bot] commented 3 months ago

Deploy Preview for poap-sdk canceled.

Name Link
Latest commit 4cc4703f86019f03d4bdbda95c86fbd16234fe0e
Latest deploy log https://app.netlify.com/sites/poap-sdk/deploys/669590dfa9f520000873ca3d