Closed olpayras closed 5 years ago
I must warn you that my index.html.tmpl has some other customizations. I can help you to isolate daylight info and you'll need to edit index.html.tmpl manually and add some keywords to weewx.conf. If you copy the whole file, even more keywords are need to control its behaviour.
Don't worry about header.html.tmpl. It is fine. Everything you need to translate is in weewx.conf or skin.conf PS: I think I understand your point now. Everytime you refresh your site you can see "weather conditions" for an instant if the connection is slow enough. I guess you could replace all of them with $Extras.home_page_header if you want. I don't kown if it breaks something else.
I searched on the web about "og". These properties belong to the open graph protocol. I don't know about its purpose. Perhaps Pat can tell us something about it, but I wouldn't worry to much.
hello every body see my website for translation in French, I don't finish the translation, I go to do any change when I saw your page translated.
http://jurassikpat.ddns.net/weewx/belchertown
Patrick
Those og are used when sharing the website on social media like Facebook. I'll make that a label for translation later when I have a few minutes.
Sent from mobile
On Mon, May 13, 2019, 1:44 PM HoracioDos notifications@github.com wrote:
I searched on the web about "og". These properties belong to the open graph protocol. I don't know about its purpose. Perhaps Pat can tell us something about it, but I wouldn't worry to much.
— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/poblabs/weewx-belchertown/issues/104?email_source=notifications&email_token=AA2SYZ7OSL6ILTVX2CLRJFTPVGSIXA5CNFSM4HHSYFQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVJBQUA#issuecomment-491919440, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2SYZ36ZCXGQOAZQRJSBQLPVGSIXANCNFSM4HHSYFQQ .
Hello guys! @poblabs, it looks like you build a French community inside this topic :-D Would it make sense that we build together an alternate "skin.conf.example_fr" that could be proposed in your skin?
@HoracioDos tkanks a lot. I'll just check your files for more details, but I'll wait for a release.
@poblabs : Tks a lot. The trouble i noticed for the translation is that :
@bonjour81 We should give a graphs.conf.example too even if everyone can custom it. With this two files, the skin will be full translated.
Maybe it could be used $Extras.site_title, already available, to fill
Hi everyone, sorry I have been delayed. My real job has me busy!
I have a quick question... For the wind rose, do you need to translate the labels around the wind rose? In Spanish, French, German, etc, are the letters different for these ordinals?
Hello Pat. In spanish the only letter that changes is W. All west ordinals are O. Luckily E, N and S match to english.
Ok I will add to my list to make those ordinals a label so you can change them.
Hi! French uses "O" for Ouest (West) too... other are same as Spanish & English (Nord, Sud, Est). Note that ordinals are defined in weewx.conf.
[[[[Ordinates]]]]
# Ordinal directions. The last one is for no wind direction
directions = N, NNE, NE, ENE, E, ESE, SE, SSE, S, SSW, SW, WSW, W, WNW, NW, NNW, N/A
Maybe those ones could be used ? (just like generic labels for barometer etc...)
This might be able to work and would be an easy thing to use! I think the problem might be the "n/a" may show as a direction. Will need to test this out.
Sent from mobile
On Tue, May 14, 2019, 9:39 AM bonjour81 notifications@github.com wrote:
Hi! French uses "O" for Ouest (West) too... other are same as Spanish & English (Nord, Sud, Est). Note that ordinals are defined in weewx.conf.
[[[[Ordinates]]]]
# Ordinal directions. The last one is for no wind direction directions = N, NNE, NE, ENE, E, ESE, SE, SSE, S, SSW, SW, WSW, W, WNW, NW, NNW, N/A
Maybe those ones could be used ? (just like generic labels for barometer etc...)
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/poblabs/weewx-belchertown/issues/104?email_source=notifications&email_token=AA2SYZYCFHHD7TCQMWQLK4TPVK6IPA5CNFSM4HHSYFQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVLQEQY#issuecomment-492241475, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2SYZZEY674KHAKPLSXBLDPVK6IPANCNFSM4HHSYFQQ .
@bonjour81 That works! I just committed it, please try it out. Thanks
Ordinal directions are OK. There is no need now to hardcode in belchertown.js.tmpl
They aren't hard coded anymore with that latest commit. 👍🏼
Sent from mobile
On Tue, May 14, 2019, 4:31 PM HoracioDos notifications@github.com wrote:
Ordinal directions are OK. There is no need now to hardcode in belchertown.js.tmpl
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/poblabs/weewx-belchertown/issues/104?email_source=notifications&email_token=AA2SYZ2LIYCE4Q7UJKSDG6DPVMOTPA5CNFSM4HHSYFQ2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVMWNXY#issuecomment-492398303, or mute the thread https://github.com/notifications/unsubscribe-auth/AA2SYZ4BIXWUF6TFNJMWYBDPVMOTPANCNFSM4HHSYFQQ .
That's true. I hardcoded them in spanish two weeks ago... (Whispering...) LOL!
@poblabs Hello Pat, I installed the update but I cannot check rose (not setup yet, my wind sensor is not ready, I'm working on building it :-)). I notice something: maybe we could use this translation also for normal wind graph ? I mean, right Y axis currently shows N / W / S / E / N from top to bottom.
@bonjour81 I just updated the header.html.tmpl and skin.conf with more translation labels. This one is different because it contained a Cheetah tag inside the original phrase. Which was $station.location. I can't add that to skin.conf, so I have to make the skin.conf labels "", then if you change them, it will update. If you leave it as "", it will keep the original default which is good since I don't want to break everyone's website who are using that original phrase.
Please test it out
@bonjour81:
I notice something: maybe we could use this translation also for normal wind graph ?
Let me try this out.
Edit: Actually I don't think this will work because it's N W S E N, which the ordinal option doesn't have. I will try it but if that doesn't work, I will make a custom graphs_windDir_ordinals
label. I'll update it
All, I removed 3 keys in the latest commit which affect how the graphs show time. For more details you can read the commit notes, and also reference Item 1 in this issue https://github.com/poblabs/weewx-belchertown/issues/124#issuecomment-492655662
Have you an example for Wind_rose config in graphs.conf (sorry i'm not very easy with highcharts :( ), so I'll check it that.
It is very simple to add, only 3 lines.
You can see that in the Wiki https://github.com/poblabs/weewx-belchertown/wiki/Belchertown-Charts-Documentation
Here is wind rose: https://github.com/poblabs/weewx-belchertown/wiki/Belchertown-Charts-Documentation#wind-rose
@bonjour81 Like I thought, using that wouldn't work. So I added a new skin.conf key that can be translated. graphs_windDir_ordinals
. Just change the "N", "E", etc. Do not change the numbers or it'll break the chart.
If this is too confusing, I can break it out more to use something like:
graphs_windDir_ordinals_N = "N"
graphs_windDir_ordinals_S = "S"
graphs_windDir_ordinals_E = "E"
graphs_windDir_ordinals_W = "W"
if that is easier?
Hello Pat. Please, could you check "og" properties and page title & description again. I added the necessary keywords to weewx.conf but it seems it doesn't work. html_site_title = "Some text" tml_site_description = "Some other text" Thanks!
@HoracioDos can you post your config and your website? It's working for me on my development site.
Hi! Wind graph right Y axis with "N, O, S , E, N" works fine! Page title & og are also good ( html_site_title & html_site_description are in skin.conf) By the way, what's the job of "og:locale" ? ( does it worth localisation or it does not matter? )
I notice I'm late with the new graphs management (groups, buttons etc...), got some work to do :-))
@bonjour81 Glad it's working. Is it simple enough to update the dictionary or do I need to break it out? Think of non-technical people who would want to update it.... ?
Good catch on og:locale. It should match your locale. I can update it to match the system locale automatically.
Here's info on the open graph protocol: http://ogp.me/
og:locale - The locale these tags are marked up in. Of the format language_TERRITORY. Default is en_US.
@poblabs do you mean update the whole file in general or do you refer to a specific point ?
@bonjour81 I mean instead of
graphs_windDir_ordinals = '{ 0: "N", 90: "E", 180: "S", 270: "W", 360: "N" }'
Maybe I should do:
graphs_windDir_ordinals_N = "N"
graphs_windDir_ordinals_S = "S"
graphs_windDir_ordinals_E = "E"
graphs_windDir_ordinals_W = "W"
?
@HoracioDos can you post your config and your website? It's working for me on my development site.
Hello Pat. I set up html keywords under [[Belchertown]] [[[Extras]]] in weewx.conf. Should I config them in skin.conf? My site is http://climacolegiales.ddns.net but luckily my new domain is accessible since this evening. So I'll migrate tonight to http://climacolegiales.com.ar
graphs_page_header = Gráficos del Clima por Período
reports_page_header = Reportes Históricos del Clima
records_page_header = Registros de Máximos y Mínimos
about_page_header = Acerca de esta Estación Meteorológica
# HTML Header Meta Tags and HTML Title. These labels have a default value
# set inside of header.html.tmpl. Leave as "" to use the default value.
html_site_title = "Condiciones actuales del clima para Colegiales - CABA - Argentina"
html_site_description = "Estación Meteorológica autónoma para el seguimiento del clima en Colegiales - CABA - Argentina"
# Records options
show_apptemp = 1
show_windrun = 1
show_cloudbase = 1
@HoracioDos They are labels like all the other translatable items, so they should be in the labels section - not Extras. Here's an example for weewx.conf:
[[Belchertown]]
skin = Belchertown
HTML_ROOT = belchertown
[[[Extras]]]
... skin extras go here ...
[[[Labels]]]
[[[[Generic]]]]
html_site_title = "Colegiales - Buenos Aires - Argentina Weather Conditions"
html_site_description = "Weather conditions for Colegiales - Buenos Aires - Argentina as observed by a personal weather station and the weewx weather software"
Palm face!!!!! Today is not my day. I'm fighting now against my new provider ftp server. Thank you very much!
You have a good point though!
Should these other items that are inside Extras be in the labels section instead?
It would break a lot of upgrades, but it would make it all in 1 place in the labels to translate.
site_title
footer_disclaimer_text
home_page_header =
graphs_page_header
records_page_header
reports_page_header
about_page_header
powered_by
@poblabs, I think graphs_windDir_ordinals is no problem. If some can translate skin.conf,they will not be stopped by this.
Maybe on top of [labels] section it could be added "# use below section for translation" So it make obvious that graphs_windDir_ordinals is part of translation area.
You have a good point though! Should these other items that are inside Extras be in the labels section instead? It would break a lot of upgrades, but it would make it all in 1 place in the labels to translate.
Hmm It is hard to say. If it is very well documented in the wiki, it could bring more order in keywords sections. On the other hand , people won't read the wiki in detail, It might demand too much time in support. If the proper way to upgrade is wiping out previous configurations it wouln't be a problem either. It could be better if you can provide a full weewx.conf example file not ony a skin.conf example when the skin is installed.
@bonjour81 Ok thanks.
@HoracioDos The upgrade plan now is to delete old files, but keep the weewx.conf config. Based on that I will leave those words in Extras so it doesn't break everyone's website when they upgrade.
Hello Pat. I'm sorry if I wasn't clear enough, I don't suggest to remove old weewx.conf, as people will need to get hands dirty removing files and editing new weewx.conf perhaps it wouldn't be a problem to switch some keywords between sections. I think it could be better to provide a proper weewx.conf as an example.
Hello Pat! Where can I translate twitter message content? I already changed hashtag and user. Thanks!
Oh that's another thing that's hard-coded. You guys are good. I'll update that so you can change it!
@HoracioDos Ok, I think I might move those to the translation labels, too, and will just point it out as a "breaking change" in the change notes. That way all text is in the same area under Labels
I used to be Quality Assurance Analyst for iSeries. I have the devil inside! LOL
Latest commit is a big one. It has breaking changes. Settings and options have moved a bit to be more in line with the labels and ability to translate.
Also, html_site_title
is now html_title
and html_site_description
is now html_description
.
Read the commit for all changes: https://github.com/poblabs/weewx-belchertown/commit/fc463c3e57252b7d171a398209966f78297a674b
@HoracioDos latest commit has a Label for twitter_text
I just solved a few conflicts and deployed into production. Hardcoded twitter message has been defeated. Once again Pat has prevailed. All other keywords were moved to their new place and everything works fine.
Hello Pat I'm almost sure I reported before but I can't find where it was. Visibility should have a comma and not a point for decimals. Thanks!
hello all people, which files should I copy to try the beta version ? thanks to you
Patrick
@HoracioDos latest commit should fix that. For me it is a period, but for you it is comma, so now it should be smart enough to decide based on language.
@salinois maybe @bonjour81 or @olpayras can help you - I think they speak French so it might be easier to explain it in French? Basically you want to follow this upgrade guide: https://github.com/poblabs/weewx-belchertown/wiki/Upgrading-to-Belchertown-skin-1.0 -- You are welcome to speak French here if it is easier! 😄
Thanks a lot Pat. It's easier for me in french.
@Salinois :
1) Tu télécharges le contenu de la branche développement au format .zip
2) Tu peux faire une copie de sauvegarde ton répertoire /etc/weewx/skins/Belchertown. Ce n'est pas obligé car les fichiers personalisés du type graphs.conf et tous les .inc que tu as personnalisé ne seront pas écrasés.
3) Depuis l'invite de commande tu tapes wee_extension --install
4) Si tu veux une traduction toute faite en francais, tu peux la récupérer sur mon repository elle est fraiche du jour, je viens d'y apporter les dernières modifs. Elle est sur ma branche History-feature, tu récupères les 2 fichiers .fra que tu renommes skin.conf et graphs.conf. Normalement tout est traduit, sinon, tu peux aussi faire ta propre traduction depuis les fichiers originaux.
Voilà, bon courage.
@olpayras @salinois I would also add that the guide should be followed too, which will remove the old [[Highcharts_Belchertown]]
items which can cause errors.
https://github.com/poblabs/weewx-belchertown/wiki/Upgrading-to-Belchertown-skin-1.0
Let me know if we need a french, spanish, german version of this. Happy to put it at the bottom.
I used skin.conf to translate your skin in french. There are very few fields who stay in english. Here are them.