poblabs / weewx-belchertown

A clean and modern weewx skin with real time streaming updates, forecast data and interactive charts. View it in action at BelchertownWeather.com
https://belchertownweather.com
GNU General Public License v3.0
209 stars 111 forks source link

Development branch errors #382

Closed HyperDevil closed 4 years ago

HyperDevil commented 4 years ago

Hi, I am using the development branch and i caught some errors. First, in the skin.conf check_for_updates was missing, so i added this manually. The images folder and the responsive-menu.js was missing i added this also. But now i am stuck with a page without the graphs:

caught ReferenceError: legend_enabled is not defined
    at Object.<anonymous> (belchertown.js?1599481876:617)
    at Function.each (jquery.min.js:2)
    at Object.success (belchertown.js?1599481876:488)
    at u (jquery.min.js:2)
    at Object.fireWith [as resolveWith] (jquery.min.js:2)
    at k (jquery.min.js:2)
    at XMLHttpRequest.<anonymous> (jquery.min.js:2)`

This came directly from the chrome console, i suspect this is causing my graphs not to work?

poblabs commented 4 years ago

The check for updates option was removed and the error you're receiving is for legend enabled and skin.conf. I don't remember this being an option but it must have been something we've added in a pull request lately. Try adding legend_enabled = 1 in skin.conf and restart weewx

On Mon, Sep 7, 2020, 8:33 AM HyperDevil notifications@github.com wrote:

Hi, I am using the development branch and i caught some errors. First, in the skin.conf check_for_updates was missing, so i added this manually. The images folder and the responsive-menu.js was missing i added this also. But now i am stuck with a page without the graphs:

caught ReferenceError: legend_enabled is not defined at Object. (belchertown.js?1599481876:617) at Function.each (jquery.min.js:2) at Object.success (belchertown.js?1599481876:488) at u (jquery.min.js:2) at Object.fireWith [as resolveWith] (jquery.min.js:2) at k (jquery.min.js:2) at XMLHttpRequest. (jquery.min.js:2)`

This came directly from the chrome console, i suspect this is causing my graphs not to work?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/poblabs/weewx-belchertown/issues/382, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA2SYZ6K7BWATJW3AAMSGMLSETHIDANCNFSM4Q6DOTNQ .

HyperDevil commented 4 years ago

Thanks for the quick feedback. Unfortunately the change had no effect:

Uncaught ReferenceError: legend_enabled is not defined
    at Object.<anonymous> (belchertown.js?1599482899:617)
    at Function.each (jquery.min.js:2)
    at Object.success (belchertown.js?1599482899:488)
    at u (jquery.min.js:2)
    at Object.fireWith [as resolveWith] (jquery.min.js:2)
    at k (jquery.min.js:2)
    at XMLHttpRequest.<anonymous> (jquery.min.js:2)
poblabs commented 4 years ago

Your error is related to these lines. It should be working as is. Can you confirm you have the latest version of the development skin and you've restarted weewx?

HyperDevil commented 4 years ago

Yes i did use the latest dev branch, git fetch then git checkout development and copied the files. Also restarted weewx many times, did some other minor changes too. Although now i am just using weewx for uploading data to weathercloud i dont need the local skin anymore. I hope nobody else bumps into this problem, if so they can re-open this case.