search

poblabs / weewx-belchertown

A clean and modern weewx skin with real time streaming updates, forecast data and interactive charts. View it in action at BelchertownWeather.com
https://belchertownweather.com
GNU General Public License v3.0
209 stars 111 forks source link

Different Rain Values if It Rains between 23:55 and 00:00 #685

Open roe-dl opened 3 years ago

roe-dl commented 3 years ago

Describe the bug If it rains between 23:55 and 00:00, the rain value displayed in the station observation section is different from the rain value displayed in snapshots section of the home page.

I did some debugging and found that hint in the WeeWX comments regarding dayRain:

                # NB: The WU considers the archive with time stamp 00:00
                # (midnight) as (wrongly) belonging to the current day
                # (instead of the previous day). But, it's their site,
                # so we'll do it their way.  That means the SELECT statement
                # is inclusive on both time ends:

So dayRain (which is sent by MQTT) is calculated different than $day.rain.sum:

The correct value is the latter.

Link to your website (IMPORTANT) https://www.woellsdorf-wetter.de

Version of the skin you're using 1.2

To Reproduce You need to wait for a day when it rains between 23:55:01 and 00:00:00. Then you see the problem without further action.

Expected behavior The daily rain is to be calculated for the time range from 00:00:01 up to now.

Device Information (please complete the following information):

Additional context I guess the solution involves introducing a second observation type for daily rain. That could be implemented by an XType extension. Such an XType extension value would be included in the MQTT output automatically.

HELP WANTED I could try to write a fix for that, but I would do so on request only, as it is some work to do.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

roe-dl commented 3 years ago

The problem still persists. And I think the reason is in the special behavior of dayRain. What do you think?

roe-dl commented 3 years ago

It is still open.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

roe-dl commented 2 years ago

The problem is still there.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

roe-dl commented 2 years ago

Still actual

roe-dl commented 2 years ago

See https://github.com/matthewwall/weewx-mqtt/pull/31

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

roe-dl commented 2 years ago

The PR I issued to weewx-mqtt is still not recognized by Matthew. So this is still actual.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

roe-dl commented 1 year ago

See https://github.com/matthewwall/weewx-mqtt/pull/33

Matthew is not sure he will include the PR into the MQTT extension. If not, a solution inside the Belchertown skin is required.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

roe-dl commented 1 year ago

There are no news about the weewx-mqtt extension. The problem persists.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

roe-dl commented 1 year ago

There are no news about the weewx-mqtt extension. The problem persists.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

roe-dl commented 1 year ago

There are no news about the weewx-mqtt extension. The problem persists.

See also https://github.com/chaunceygardiner/weewx-rain24h