poblish / bannedList-Plugin

#BannedList Plugin
3 stars 1 forks source link

Ignore stats submissions from Intranets, etc. #27

Closed poblish closed 12 years ago

poblish commented 12 years ago

We don't want to get stats submissions from people's Intranets, orivate networks, etc., even though we don't grab any sensitive data. See my question for more: http://stackoverflow.com/questions/10505450/distinguish-intranet-and-external-ip-addresses-in-javascript

Options:

1) Wait for better suggestions 2) Use the suggested IP lookup approach for Firefox, do a remote IP lookup for Chrome via some service. 3) Use the suggested IP lookup approach for Firefox, ask our own submission service to do the IP lookup for Chrome, then ignore or carry on. 4) Use our submission service for both browsers.

Using our own submission service would be simpler (and more stable?!?) than doing it on the client. Wouldn't be any more hits than now, because we'd only do it when score > 10 (though we miss the chance to reduce the number of hits!). Main issue, though, is: how do we give user visual feedback? Return a special value to the client and use that to clear the number from the App icon?

Perhaps visual feedback is not important: solve the first issue of Intranet results getting into Results. Worry about visual feedback after...?

poblish commented 12 years ago

Change of plan - no server-side stuff at all. Fixed via http://stackoverflow.com/questions/10505450/distinguish-intranet-and-external-ip-addresses-in-javascript and http://stackoverflow.com/questions/10269321/content-script-events-sent-by-functions-callbacks-not-received-by-add-on-script