search

pobrn / qc71_laptop

Linux kernel platform driver for QC71 based laptops.
GNU General Public License v2.0
31 stars 11 forks source link

Does not build with kernel 6.2.1-arch1-1 #14

Closed jomp16 closed 1 year ago

jomp16 commented 1 year ago 
❯ cat /var/lib/dkms/qc71_laptop/r63.28106e0/build/make.log
DKMS make.log for qc71_laptop-r63.28106e0 for kernel 6.2.1-arch1-1 (x86_64)
qua 01 mar 2023 09:28:12 -03
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/ec.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/features.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/main.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/misc.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/pdev.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/events.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/debugfs.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/battery.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/led_lightbar.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/hwmon_fan.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/hwmon.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/hwmon_pwm.o
  CC [M]  /var/lib/dkms/qc71_laptop/r63.28106e0/build/fan.o
/var/lib/dkms/qc71_laptop/r63.28106e0/build/fan.c: In function ‘qc71_fan_set_mode’:
/var/lib/dkms/qc71_laptop/r63.28106e0/build/fan.c:197:32: warning: ignoring return value of ‘ec_write_byte’ declared with attribute ‘warn_unused_result’ [-Wunused-result]
  197 |                         (void) ec_write_byte(FAN_CTRL_ADDR, 0x80 | FAN_CTRL_AUTO);
      |                                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/qc71_laptop/r63.28106e0/build/battery.c:93:27: error: initialization of ‘int (*)(struct power_supply *, struct acpi_battery_hook *)’ from incompatible pointer type ‘int (*)(struct power_supply *)’ [-Werror=incompatible-pointer-types]
   93 |         .add_battery    = qc71_laptop_batt_add,
      |                           ^~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/qc71_laptop/r63.28106e0/build/battery.c:93:27: note: (near initialization for ‘qc71_laptop_batt_hook.add_battery’)
/var/lib/dkms/qc71_laptop/r63.28106e0/build/battery.c:94:27: error: initialization of ‘int (*)(struct power_supply *, struct acpi_battery_hook *)’ from incompatible pointer type ‘int (*)(struct power_supply *)’ [-Werror=incompatible-pointer-types]
   94 |         .remove_battery = qc71_laptop_batt_remove,
      |                           ^~~~~~~~~~~~~~~~~~~~~~~
/var/lib/dkms/qc71_laptop/r63.28106e0/build/battery.c:94:27: note: (near initialization for ‘qc71_laptop_batt_hook.remove_battery’)
cc1: some warnings being treated as errors
make[1]: *** [scripts/Makefile.build:252: /var/lib/dkms/qc71_laptop/r63.28106e0/build/battery.o] Error 1
make[1]: ** Esperando que outros processos terminem.
make: *** [Makefile:2021: /var/lib/dkms/qc71_laptop/r63.28106e0/build] Error 2
jomp16 commented 1 year ago

By adding struct acpi_battery_hook *hook to the qc71_laptop_batt_add and qc71_laptop_batt_remove makes it build correctly.

pobrn commented 1 year ago

Please reopen if it still does not work.