search

pocc / bga_discord

Discord bot to create games on Board Game Arena
Apache License 2.0
11 stars 5 forks source link

Should files end with a newline character? #8

Closed mavit closed 3 years ago

mavit commented 3 years ago

I find that files in this project tend not to end in a newline, whereas my text editor is keen that files should end in a newline. This causes messy diffs.

The EditorConfig standard is supported by many text editors, and could be used to tell them to behave in the way preferred by this project's maintainer.

pocc commented 3 years ago

You are right.

Per PEP8 code W292, this is standard in the Python language (and text files traditionally). I think a better way to do this is run pre-commit over this with a couple linters and setup travis to run that on commit.

I'll be able to expand on this more later.