fixing behaviour of file patterns in istanbul

pocesar / grunt-mocha-istanbul

Almost config-free Istanbul code coverage reporter for Mocha usage in Grunt

MIT License

75 stars 23 forks source link

fixing behaviour of file patterns in istanbul #61

Closed leider closed 8 years ago

leider commented 8 years ago

the erronous new behaviour was introduced with version 5.0.0

the necessary changes are in file index.js - the other files contain corrections to the dependencies and illustrations of the behaviour: the new test must not show the coverage of file "other.js" in the coverage report.

questions? - feel free to ask

btw. version 5.0.* break our builds (softwerkskammer/Agora)

pocesar commented 8 years ago

oops, the patterns given to istanbul aren't really a minimatch for files, they are actually filters and shouldn't have their full paths (should be contained to the work dir / root of the sources)

pocesar commented 8 years ago

released as 5.0.2

leider commented 8 years ago

Thanks. That was quick!

pocesar commented 8 years ago

good thing I barely have leisure time haha