search

pocheshire / BottomNavigationBar

Bottom Navigation Bar for Xamarin
214 stars 70 forks source link

Provide properties to set BarBackground and inactive icon color in fixed Mode #27

Closed escamoteur closed 7 years ago

escamoteur commented 7 years ago

Hi,

I'm working on extending the Xamarin.Forms version of Bottombar. I'm struggling to set the Bar background color to black and figred the only way is to call _bottomBar.UseDarkThemeWithAlpha(true); and add a color definition for bb_darkBackgroundColor in my colors.xml.

Also I found that setting "white" in the colors.xml changes the inactive icons in darcktheme.

I think it would be much more comfortable to expose this color as a property that can be set directly.

What do you think?

Best Thomas

pocheshire commented 7 years ago

Hi,

Maybe in version 2.0

zonkzen commented 7 years ago

Also, this approach reserves "white" color and many times it actually has to be set to something else than "#FFFFFF". It would be good to give it a more meaningful name or at least a prefix like for 'bb_darkBackgroundColor'.

pocheshire commented 7 years ago

white renamed to bb_darkInActiveBottomBarItemColor in 1.4.0.3 version