code path android bootcamp prework review

pochunhsu / SimpleToDo

codepath android bootcamp prework

0 stars 0 forks source link

code path android bootcamp prework review #1

Open pochunhsu opened 8 years ago

pochunhsu commented 8 years ago

@codepathreview @codepath

nesquena commented 8 years ago

Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a code review for each submitted project.

The next step is to continue working on extensions to your todo app and to schedule a short 10 minute phone conversation with us. Navigate to today's date and onward from there and choose a 15-minute slot. Let us know if none of those times work.

Once you select a slot, can you make sure to include best number to reach you at to the invite? Look forward to chatting soon!

pochunhsu commented 8 years ago

Nice to chat with you today. If you get chance reviewing my repo, please let me know if I missed any suggested feature or if you have any suggestion. Thank you. : D

nesquena commented 8 years ago

Good chatting with you as well. High level, I'd like to see you push your understanding of Android user experience and improving the feel of the app. Take a look at the a top past submission to get a clearer idea. Here's a few suggestions for your app to push it a bit farther in terms of UI:

The clickable bar buttons at the bottom isn't really how android apps create action buttons. I'd encourage you to check how other apps do it and see if you can use the guides to improve the UI.
The date selection as it is now uses the date picker but it's clunky embedded into the activity. I'd like to see you investigate ways to make the user experience better. For example, using a nicer looking date picker dialog.

I'd also like to see other more creative functionality additions such as investigating how to notify the user using an alarm when one of their todo items is becoming due.

There are guides for all of these on the CodePath materials.

pochunhsu commented 8 years ago

I updated the UI and added the notification accordingly. The new demo is also added in the readme. I hope this one meet your expectation. Please take a look and let me know if there is any finishing touch needed. Thank you,

nesquena commented 8 years ago

Great to see you were able to augment your app with a number of extension tasks now and improve the user experience. As mentioned earlier, the extension tasks available on each project are often the most valuable learnings since they dive deeper into common real-world Android use cases.

We'll be in touch with you again soon via email. Let me know if you have any questions about the project or anything in the meantime.