pock / weather-widget

Stay updated with the latest weather forecast for your current location.
5 stars 5 forks source link

Major Changes to weather widget #10

Open cshariq opened 1 year ago

cshariq commented 1 year ago

I have done some major changes to the weather widget to enhance it. These are the following changes:

When looking at the files changed section you can filter .png and .json files as they're all the new icons/assets and don't require any checking.

pigigaldi commented 1 year ago

Thank you for you hard work! I'll try to review this asap :)

Just a quick tip for the future, you should avoid putting all changes into a single commit. Next time you could try split changes across multiple commits, with meaningful commit message (see other commits for message structure). This would make the review process much easier! :)

cshariq commented 1 year ago

Ok thanks for the feedback, i've just started using GitHub, in fact this is my 2nd pull request. I'll try to keep your tips in mind for future commits.