pocke / oshirase

WIP
1 stars 1 forks source link

Firefox not dispaying notifications #1

Open CamilleScholtz opened 5 years ago

CamilleScholtz commented 5 years ago

Hey, thanks a lot for creating this package! I used it to create my own little notification daemon: https://github.com/onodera-punpun/melonnotifier

It works perfectly, however Firefox doesn't use it for some reason (instead Firefox displays it's own XUL alerts, though I've set it to use native libnotify in about:config). Do you have any idea why this is? Maybe something isn't supported?

CamilleScholtz commented 5 years ago

Seems like adding actions to https://github.com/pocke/oshirase/blob/master/messages.go#L23 fixes this. Should I submit a PR?

pocke commented 5 years ago

Thank you for your feedback!

Sorry, I don't maintain this package now, so I don't remember the source code, design, specification, and so on. If you'd like, I'll add you to the collaborators of this repository. Feel free developing on this repository.

CamilleScholtz commented 5 years ago

I don't know anything about the lib-notify spec though, so I'm not really confident in maintaining the package. Is it alright if I just submit the one line PR?

pocke commented 5 years ago

Sure! Please open a pull request :+1: