pockerman / cuberl

Library for reinforcement learning with c++
https://pockerman-py-cubeai.readthedocs.io/en/latest/
3 stars 1 forks source link

Optimizer should be removed from RL trainers #125

Closed pockerman closed 3 months ago

pockerman commented 4 months ago

The constructor

PyTorchRLTrainer(const PyTorchRLTrainerConfig config, agent_type& agent,
                     std::unique_ptr<torch::optim::Optimizer> optimizer);

of PyTorchRLTrainer class accepts an optimizer. This should be removed the PyTorch based solvers should handle the optimization aspect