search

pocketarc / codeigniter

Fork of CI3 kept up to date with PHP 8.3 (and beyond; will be maintained indefinitely).
MIT License
53 stars 14 forks source link

Redis cache incompatibility #10

Open kissit opened 3 months ago

kissit commented 3 months ago

It looks like the version of system/libraries/Cache/drivers/Cache_redis.php in the fork was being re-worked in the source develop branch and is throwing the following warning. Furthermore, even just fixing the warning, I don't think the code looks complete (no setting of TTL in the save function for instance, also increment/decrement wouldn't really fit the new way of storing the keys/data types/values).

I ended up just reverting the entire file from the prior 3.1.13 release which seems to work as expected, but didn't know if that was the desired fix for you.

A PHP Error was encountered
Severity: Warning

Message: Undefined variable $value

Filename: drivers/Cache_redis.php

Line Number: 166
siemova commented 2 months ago

I opened a PR after encountering the same problem. However, I'd suggest that it might be a good idea to fork and maintain the source repo's master branch—whether instead of or in addition to the development branch—for users who don't want (or expect!) any WIP changes like these. I certainly appreciate what's been done already, though!