search

pocketarc / codeigniter

Fork of CI3 kept up to date with PHP 8.4 (and beyond; will be maintained indefinitely).
MIT License
80 stars 15 forks source link

Continuous integration is not running #9

Open RedDragonWebDesign opened 7 months ago

RedDragonWebDesign commented 7 months ago

Would be good to get CI up and running. We could add PHP 8.3 to it and see if it passes.

I wonder if it's missing some secrets.

poodle123 commented 7 months ago

The current release works perfectly fine on PHP 8.3.4

Did you encounter any specific errors that should be adressed?

RedDragonWebDesign commented 7 months ago

What does your comment have to do with continuous integration? Not sure you're understanding the ticket completely.

poodle123 commented 7 months ago

Looks like I didnt understand your issue then. Sorry about that.

RedDragonWebDesign commented 7 months ago

It's all good. Just to be clear, this ticket is about continuous integration, which is the tests that run every time a commit or pull request is added to this GitHub repository. Passing the tests puts a little green check mark next to the commit, failing the tests puts a red X.

image


image

Having continuous integration is a good practice. It lets you see if new code changes break anything.

The repo this was forked from had working continuous integration. But forking it broke CI for this repo. This ticket is to fix it.

Right now the tests only run up to PHP 8.2. In the future we'd want to add PHP 8.3 to it. I can write a patch for that once CI is fixed.

pocketarc commented 2 weeks ago

@RedDragonWebDesign Sorry for not getting this up and running sooner - it's now up! There'll definitely be work to be done for getting things testing on PHP 8.3/8.4, is that something you're still interested in looking at?