Corrupt uploading Font, Ico files

pocketarc / git-deploy-php

git-deploy-php is a simple php-based tool that deploys your Git repositories to FTP/SFTP servers, and keeps them updated automatically.

http://brunodebarros.github.io/git-deploy-php

292 stars 45 forks source link

Corrupt uploading Font, Ico files #27

Closed dipsynl closed 10 years ago

dipsynl commented 11 years ago

When uploading fonts from extensions .woff .eot .ttf .svg .otf they become corrupt. It seems that they are uploaded in ASCII mode instead of binary mode. Favicon with the extension .ico has the same problem.

pocketarc commented 11 years ago

Are you using FTP or SFTP for deployments? In FTP, all files are uploaded using FTP_BINARY, so the problem shouldn't lie there.

dipsynl commented 11 years ago

On FTP i have the problem and also on SFTP. It happens with all sites / servers.

pocketarc commented 10 years ago

This is caused by git-show, the tool I use to get the contents of any file at any given commit; I've just reproduced the issue. Am trying to resolve it now.

dipsynl commented 10 years ago

Great news!! At my work we use this program to deploy all our sites. It saved us a lot of time.

pocketarc commented 10 years ago

I'm really glad to hear that! :smile: Sorry it took so long to resolve this issue. At least it's sorted now. (I've already tested and am committing it now) Let me know if you ever have problems again.