search

pockethub / PocketHub

PocketHub Android App
Apache License 2.0
9.39k stars 3.46k forks source link

Migration to GitHubSdk 0.5 #1158

Closed plweegie closed 6 years ago

plweegie commented 6 years ago

I thought it might be a good idea to connect the app to the new version of the SDK, which is much more flexible and will allow for more features to be added later, following up from https://github.com/Meisolsson/GitHubSdk/pull/13. There are a couple of breaking changes and I have rewritten a number of classes and tests to take that into account. Because classes in com.github.pockethub.android.ui.item.news have been the most heavily affected, I also decided to migrate that package to Kotlin.

plweegie commented 6 years ago

Thanks for the review. I will fix the tests for 0.5.1 and optimize some of the other things you mentioned as soon as I can. Will also keep PRs simple in the future.

plweegie commented 6 years ago

I made the changes for the minor comments. I have the migration to 0.5.1 with all the tests passing on a feature branch. I'm assuming you'd prefer that as a separate PR, otherwise I can push the changes here. Let me know.

Meisolsson commented 6 years ago

Well the changes to 0.5.1 would probably be nice to have in this since it's just for the RepoIdentifier. Other than that the only thing i still want changed is the imports which changed all over the place.

plweegie commented 6 years ago

Ok, this should do it then.

Meisolsson commented 6 years ago

Looks good.