search

pockethub / PocketHub

PocketHub Android App
Apache License 2.0
9.39k stars 3.46k forks source link

Fix issues loading fail #1164

Closed plweegie closed 6 years ago

plweegie commented 6 years ago

I'm not sure whether that relates to #1100 or not, the description there was not clear enough.

This is something that I've discovered myself, com.github.pockethub.android.ui.issue.IssueFragment was showing an error and an empty list due to null arguments being passed somewhere along the Rx workflow in refreshIssue(). This has now been fixed.

Meisolsson commented 6 years ago

Well it's probably better if we just don't pass null. I think the best fix here is to figure out why we passed null to it in the first place.

Looking at it we could probably just pass an empty collection to as events instead of the null we are passing now. Regaring the issue being null that's more or a problem which I don't understand. Ther should be no way for an issue to be null in this case from what I know.

plweegie commented 6 years ago

There was indeed a call when we passed null as events to FullIssue. That was the only parameter causing problems. The fix will allow us to keep non-nullability in the FullIssue constructor.