search

pockethub / PocketHub

PocketHub Android App
Apache License 2.0
9.39k stars 3.46k forks source link

Move more progress bar displaying responsibility to RxProgress #1174

Closed veyndan closed 6 years ago

veyndan commented 6 years ago

In order to do this, ImageBin was modified from a callback based approach using OkHttp to using RxJava.

Each commit is fairly descriptive in what I did, so I'm not going to go into too much detail of what I did.

veyndan commented 6 years ago

Rebased.

veyndan commented 6 years ago

Done.

Out of interest, do you get notifications when I rebase or add another commit? I'm never sure if the messages stating whether I have rebased or added a commit is necessary.

Meisolsson commented 6 years ago

From what I know there is not any notification when there are new commits or rebasing. Not something I've really checked.

Meisolsson commented 6 years ago

Look like there are some conflicts, after those are fixed you can just merge it