pockethub / PocketHub

PocketHub Android App
Apache License 2.0
9.4k stars 3.46k forks source link

Specific file open leads to a crash #405

Open dkrikun opened 11 years ago

dkrikun commented 11 years ago

Trying to open https://github.com/discourse/discourse/blob/master/docs/VAGRANT.md leads to a crash.

On android 4.3, nexus 4 phone

atermenji commented 11 years ago

do you open this file from a browser?

dkrikun commented 11 years ago

In a browser it opens fine, the crash happens in android native app.

atermenji commented 11 years ago

I'm trying to open this file by clicking on the link and selecting GitHub app in the app chooser dialog but I see no crash. Though the file is not opening. Opening this file directly from the code browsing screen in mobile app works fine. I'm testing on Galaxy Nexus, Android 4.3. Can you please add a log of the crash?

dkrikun commented 11 years ago

My bad, it is another file, to reproduce, I do the following: Go to discourse/discourse repo --> code tab --> docs folder --> open VAGRANT.md --> click on 'Discourse Advanced Developer Guide' --> now it crashes How can I add the log? I have sent it via android crash report w/ description 'discourse crash', but I see no option to copy & paste it.

jojosch commented 11 years ago

i can confirm this on a HTC One X with Cyanogenmod 10.2 Android 4.3:

Log:

I/ActivityManager(  543): START u0 {act=com.github.mobile.branch.file.VIEW cmp=com.github.mobile/.ui.ref.BranchFileViewActivity (has extras)} from pid 19663
I/ActivityManager(  543): Displayed com.github.mobile/.ui.ref.BranchFileViewActivity: +223ms
D/TilesManager(19663): Starting TG #0, 0x5ca42ec8
D/TilesManager(19663): new EGLContext from framework: 40026fc0 
D/GLWebViewState(19663): Reinit shader
D/GLWebViewState(19663): Reinit transferQueue
I/ActivityManager(  543): START u0 {act=android.intent.action.VIEW cat=[android.intent.category.BROWSABLE] dat=DEVELOPER-ADVANCED.md} from pid 19663
D/AndroidRuntime(19663): Shutting down VM
W/dalvikvm(19663): threadid=1: thread exiting with uncaught exception (group=0x41e2b700)
E/AndroidRuntime(19663): FATAL EXCEPTION: main
E/AndroidRuntime(19663): android.content.ActivityNotFoundException: No Activity found to handle Intent { act=android.intent.action.VIEW cat=[android.intent.category.BROWSABLE] dat=DEVELOPER-ADVANCED.md }
E/AndroidRuntime(19663):    at android.app.Instrumentation.checkStartActivityResult(Instrumentation.java:1632)
E/AndroidRuntime(19663):    at android.app.Instrumentation.execStartActivity(Instrumentation.java:1424)
E/AndroidRuntime(19663):    at android.app.Activity.startActivityForResult(Activity.java:3390)
E/AndroidRuntime(19663):    at android.app.Activity.startActivityForResult(Activity.java:3351)
E/AndroidRuntime(19663):    at android.support.v4.app.FragmentActivity.startActivityForResult(FragmentActivity.java:674)
E/AndroidRuntime(19663):    at android.app.Activity.startActivity(Activity.java:3587)
E/AndroidRuntime(19663):    at android.app.Activity.startActivity(Activity.java:3555)
E/AndroidRuntime(19663):    at com.github.mobile.util.SourceEditor$1.shouldOverrideUrlLoading(SourceEditor.java:69)
E/AndroidRuntime(19663):    at android.webkit.CallbackProxy.uiOverrideUrlLoading(CallbackProxy.java:261)
E/AndroidRuntime(19663):    at android.webkit.CallbackProxy.handleMessage(CallbackProxy.java:363)
E/AndroidRuntime(19663):    at android.os.Handler.dispatchMessage(Handler.java:99)
E/AndroidRuntime(19663):    at android.os.Looper.loop(Looper.java:137)
E/AndroidRuntime(19663):    at android.app.ActivityThread.main(ActivityThread.java:5289)
E/AndroidRuntime(19663):    at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime(19663):    at java.lang.reflect.Method.invoke(Method.java:525)
E/AndroidRuntime(19663):    at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:739)
E/AndroidRuntime(19663):    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:555)
E/AndroidRuntime(19663):    at dalvik.system.NativeStart.main(Native Method)
W/ActivityManager(  543):   Force finishing activity com.github.mobile/.ui.ref.BranchFileViewActivity
W/ActivityManager(  543): Activity pause timeout for ActivityRecord{422b0b48 u0 com.github.mobile/.ui.ref.BranchFileViewActivity}
atermenji commented 11 years ago

Thanks, now I see the problem, will try to fix soon.