search

pocketnetteam / pocketnet.core

Decentralized social network based on the blockchain
https://pocketnet.app
Apache License 2.0
114 stars 28 forks source link

Long shutdown 0.21 #256

Closed lostystyg closed 2 years ago

lostystyg commented 2 years ago

Shutdown time is increased a lot n 0.21. This is because staker thread (and probably someone else) is not exit its loop immediately after shutdown called.

andyoknen commented 2 years ago

I'm trying to solve this problem here https://github.com/pocketnetteam/pocketnet.core/pull/284

This method ignores some threads because m_fRunning = false https://github.com/pocketnetteam/pocketnet.core/blob/0954d8c76aed0611e887f88cfdec6dcd5ac863eb/src/eventloop.h#L197-L208

Perhaps this is due to the number of threads - I tested on a system that runs more than 100 threads for public RPC

the-real-vortex-v commented 2 years ago

Nothing in the process is being shut down it seems. When I look at the running process in windows all the network activity is still happening happily.

I'm running it on windows 10. Someone else also mentioned this bug this week in the node chat.

andyoknen commented 2 years ago

Fixed in https://github.com/pocketnetteam/pocketnet.core/pull/284/commits/932d3a6cd6e82e32023477ffbcae49e377957894

lostystyg commented 2 years ago

339 related