search

pocketsize / bolts-wp

A starter theme for WordPress using Bolts
2 stars 0 forks source link

components: not able to pass false theme argument in nested data to avoid default theme #67

Closed djurnamn closed 5 years ago

djurnamn commented 5 years ago

when I pass $theme = false to a component that calls another component, it's interpreted as null and sets theme default. we need to handle this in either the ´modifiers´ function or rethink how we null check.

djurnamn commented 5 years ago

might actually just be the link component where we do this null check: $theme = !empty($theme) ? $theme : null;

doing this instead could solve the problem: $theme = isset($theme) ? $theme : null;

djurnamn commented 5 years ago

fixed in #74!