search

pocketworks / git2pdf

Print physical Kanban cards from your GitHub issues, and stick that sweet stuff on your office wall
http://www.pocketworks.co.uk/blog/2014-07-01-announcing-git2pdf
MIT License
51 stars 15 forks source link

Added loop to pull all matching issues from Github instead of only one pageful. #10

Closed RichardWallis closed 7 years ago

RichardWallis commented 8 years ago

Added loop to pull all matching issues from Github instead of only one of their pagefuls (100) Fixes Issue (#4)

RichardWallis commented 8 years ago

Note: This works when running bin/git2pdf but as a newbie to Ruby I couldn't get 'gem install git2pdf' to update /usr/bin/git2pdf with this new version.

jgrau commented 8 years ago

In order for gem install git2pdf to be updated with your changes your PR will have to be merged and then a new release created on rubygems. After that, updating the gem would include your changes. AFAIK :)

RichardWallis commented 8 years ago

Also Added new command line option -i to include (Yes|No|Only) Pull Requests in commit de93567

RichardWallis commented 8 years ago

Another tweak recognising that some labels include characters that need encoding before sending to to the GitHub API eg: bin/git2pdf gen schemaorg/schemaorg --labels "site tools + python code"

Is there any enthusiasm to merge this PR and update the release on rubygems as @jgrau explains?

I am finding the capability to output all issues/pull requests, and all with a particular label assigned, a very useful option.

jgrau commented 8 years ago

Pocketworks, if you would like a maintainer for this library I wouldn't mind taking over...?

tobinharris commented 7 years ago

@jgrau Many thanks. I'm not sure why I only just saw this comment now.

Are you still open to being a maintainer?

wordswords commented 7 years ago

If @jgrau isn't interested anymore then I would be happy to be a maintainer if needed.

jgrau commented 7 years ago

We don't actively use git2pdf anymore (although I could easily see us use it in the future). @wordswords, you seem more interested than me so I would think the project would benefit the most from having you as the maintainer :)

tobinharris commented 7 years ago

Thanks David / @wordswords. Ok, that's awesome, thank you. I'll add you to the repo. Feel free to add any credits to the READEME. And also feel free to credit any contributors :)

tobinharris commented 7 years ago

Also, let me know when you want me to re-publish the gem, I can make sure the latest is out there.

tobinharris commented 7 years ago

@wordswords ^^

wordswords commented 7 years ago

@tobinharris that's great, thanks! Will let you know when the gem needs to be republished