Closed pocmo closed 4 years ago
Can I work on this?
Yep! Assigned. :)
I need one too. I have been following with curiosity and now I want to contribute.
@jerryOkafor Maybe issue #73 to start? I'll make sure to file some more issues today. :)
Sure. I will work on it.
XML attribute: https://developer.android.com/reference/android/widget/TextView?hl=en#attr_android:maxLines
Jetpack Compose:
We are parsing
TextView
here: https://github.com/pocmo/recompose/blob/main/recompose-parser/src/main/kotlin/recompose/parser/xml/view/TextView.ktAnd create a
TextViewNode
from it: https://github.com/pocmo/recompose/blob/main/recompose-ast/src/main/kotlin/recompose/ast/view/TextViewNode.ktAnd we turn the node into Kotlin code here: https://github.com/pocmo/recompose/blob/main/recompose-composer/src/main/kotlin/recompose/composer/visitor/ComposingVisitor.kt#L82-L94
To solve this issue:
TextViewNode
. Probably a nullableInt?
is needed.ComposingVisitor
.ParserTest
andComposerTest
.