search

pocmo / recompose

recompose is a tool for converting Android layouts in XML to Kotlin code using Jetpack Compose.
Apache License 2.0
783 stars 49 forks source link

Issue #65 Add "Don't show this dialog next time" checkbox to plugin prompt #80

Closed t-regbs closed 3 years ago

t-regbs commented 3 years ago

Addresses #65

t-regbs commented 3 years ago

I wrote an implementation for the PersistentStateComponent as suggested by @Foso and also added a Configurable where a plugin user would be able to configure their preferences from the plugin’s tab inside the IDE’s preferences window.

t-regbs commented 3 years ago

@pocmo Hi, any feedback on this?

pocmo commented 3 years ago

When the setting is deselected, the Xml is still converted to Compose

@t-regbs Is this fixed in the latest version?

pocmo commented 3 years ago

Oh, there's now also a PR with different implementation in #100.

t-regbs commented 3 years ago

yes that is fixed in the latest version @pocmo

t-regbs commented 3 years ago

@pocmo Just checked out the other implementation and it looks good. Only functional difference is I also added settings for showing the dialog and also turning on or off conversion to compose altogether in Preferences.

pocmo commented 3 years ago

Thank you for your work! 👍 I rebased and landed your changes in #106. :)