search

pocopico / tinycore-redpill

GNU General Public License v3.0
2.14k stars 631 forks source link

user_config.json file looks corrupted #294

Closed damienmillet closed 1 year ago

damienmillet commented 1 year ago

Contexte

on html :

ps : it should be nice to create a issue model ;)

pocopico commented 1 year ago

I have opened the discussions if you like you can be the second user :)

pocopico commented 1 year ago

ps : it should be nice to create a issue model ;)

What will that do ? can you elaborate please ?

damienmillet commented 1 year ago

I talk about a method to write issue to get more information, that can be useful sometime. Contexte ? Version ? Web or Cli ? Manual or Auto ?

to help to understand the situation to fix it or explain

pocopico commented 1 year ago

Oh yes i get it , that for me to be able to test should then be smg like :

Build Method (html/cli) : Selected Model & Version (e.g. DS3622xs 7.1.1 42952) : Command issued: Result : Suggested Fix:

damienmillet commented 1 year ago

yes !! take a look: https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/configuring-issue-templates-for-your-repository

pocopico commented 1 year ago

Nice !

pocopico commented 1 year ago

I've updated the user_config.json update function and it now looks more stable. Using file to store the changed contents instead of using a bash variable.

damienmillet commented 1 year ago

tested if I update Mac and SN then build error !

damienmillet commented 1 year ago

I FOUND IT ! 😃 when we reset the model, sometimes the version isn't returned to the request, like : http://xx.xx.xx.xx/index.sh?action=build&mymodel=DS3622xs+&myversion= then when I ask to use my realmac an error is catch !

Error both /home/tc/user_config.json file looks corrupted, select Additional Actions -> Reset model to recreate if I change the url to : http://xx.xx.xx.xx/index.sh?action=build&mymodel=DS3622xs+&myversion=7.2.0-64551 it's nice 😉

damienmillet commented 1 year ago

damned I closed it without ur patch to fix haha

damienmillet commented 1 year ago

ok when I did it, the model haven't + for 3622 cause + is a used by http, should be replace with p or %2A

pocopico commented 1 year ago

The issue was caused by overlapping user_config json updated, implemented a wait mechanism for each value to be applied.