ds918p-7.2.0-64561 not support redpill-load/raw/master/redpill-acpid

[namvan]

Describe the bug Issue only at build time. Adding it is okay. Command

./rploader.sh ext ds918p-7.2.0-64561 add https://github.com/pocopico/redpill-load/raw/master/redpill-acpid/rpext-index.json

To Reproduce As an example ./rploader.sh ext ds918p-7.2.0-64561 add https://github.com/pocopico/redpill-load/raw/master/redpill-acpid/rpext-index.json

Full logs is below

[-] The extension jumkey.acpid2 was found. However, the extension index has no recipe for ds918p_64561 platform. It may not be
[-] supported on that platform, or author didn't updated it for that platform yet. You can try running
[-] "ext-manager.sh update" to refresh indexes for all extensions manually. Below are the currently known information about
[-] the extension stored locally:
[#] ========================================== jumkey.acpid2 ==========================================
[#] Extension name: ACPI Daemon v2
[#] Description: ACPI Daemon v2 that handles power button events
[#] To get help visit: https://github.com/jumkey/redpill-load/raw/develop/redpill-acpid
[#] Extension preparer/packer: https://github.com/jumkey/redpill-load/raw/develop/redpill-acpid
[#] Software author: https://sourceforge.net/projects/acpid2/
[#] Update URL: https://github.com/pocopico/redpill-load/raw/develop/redpill-acpid/rpext-index.json
[#] Platforms supported: ds1621p_42218 ds1621p_42951 ds918p_41890 ds3617xs_42621 ds3617xs_42218 ds920p_42661 ds918p_42661 ds3622xsp_42962 ds3617xs_42951 ds920p_42962 ds1621p_42661 ds918p_25556 ds3615xs_42661 ds3622xsp_42661 ds2422p_42661 ds3622xsp_42218 ds2422p_42962 ds2422p_42218 ds3615xs_42962 ds3617xs_42962 ds3615xs_41222 ds920p_42951 ds2422p_42951 ds918p_42621 ds3617xs_42661 ds3615xs_25556 ds920p_42218 ds920p_42621 ds918p_42962 ds3615xs_42951 ds3622xsp_42951 ds920p_42550 ds918p_42218 ds2422p_42621 ds1621p_42621 ds3615xs_42621 ds3615xs_42218 ds1621p_42962 ds3622xsp_42621 
[#] =======================================================================================

[-] Failed to update recipe for jumkey.acpid2 extension for platform ds918p_64561. The script will terminate as you do not
[-] have previously downloaded recipe which can be used if download fails. Try again later. If problem
[-] persists contact the extension packer for support (displayed below)
[#] ========================================== jumkey.acpid2 ==========================================
[#] Extension name: ACPI Daemon v2
[#] Description: ACPI Daemon v2 that handles power button events
[#] To get help visit: https://github.com/jumkey/redpill-load/raw/develop/redpill-acpid
[#] Extension preparer/packer: https://github.com/jumkey/redpill-load/raw/develop/redpill-acpid
[#] Software author: https://sourceforge.net/projects/acpid2/
[#] Update URL: https://github.com/pocopico/redpill-load/raw/develop/redpill-acpid/rpext-index.json
[#] Platforms supported: ds1621p_42218 ds1621p_42951 ds918p_41890 ds3617xs_42621 ds3617xs_42218 ds920p_42661 ds918p_42661 ds3622xsp_42962 ds3617xs_42951 ds920p_42962 ds1621p_42661 ds918p_25556 ds3615xs_42661 ds3622xsp_42661 ds2422p_42661 ds3622xsp_42218 ds2422p_42962 ds2422p_42218 ds3615xs_42962 ds3617xs_42962 ds3615xs_41222 ds920p_42951 ds2422p_42951 ds918p_42621 ds3617xs_42661 ds3615xs_25556 ds920p_42218 ds920p_42621 ds918p_42962 ds3615xs_42951 ds3622xsp_42951 ds920p_42550 ds918p_42218 ds2422p_42621 ds1621p_42621 ds3615xs_42621 ds3615xs_42218 ds1621p_42962 ds3622xsp_42621 
[#] =======================================================================================

[!] Cannot continue due to previous errors (see above)

*** Process will exit ***
[!] Failed to update all extensions for ds918p_64561 platform - see errors above

*** Process will exit ***

[pocopico]

Please use : https://github.com/pocopico/tcrp-addons/raw/main/acpid/rpext-index.json

[namvan]

Thank you. Will the below be soon supported? I had tried to fork and made a change but don't know enough yet to make it work via copy/paste.

./rploader.sh ext ds918p-7.2.0-64561 add https://github.com/pocopico/tcrp-addons/raw/main/virtio/rpext-index.json

[pocopico]

The virtio modules are included in the all-modules extension. If though you are still missing something you can ping me

[namvan]

Well, it did not seem so when I used the latest loader in a test VM. Here is what I have done

1. After building the loader and loading up, the NIC, which was selected as virtio device, was not avail. Can't check disk as the Assistant can't find the box yet.
2. Switched the NIC to e1000e, rebuilt the loader, then booted up again. Now can find the box but opening it up with Synology Assistant said "No drives detected"

Below is all the commands issued

./rploader.sh update
./rploader.sh fullupgrade
./rploader.sh serialgen DS918+
./rploader.sh satamap
./rploader.sh ext ds918p-7.2.0-64561 add https://github.com/pocopico/tcrp-addons/raw/main/acpid/rpext-index.json
./rploader.sh ext ds918p-7.2.0-64561 add https://github.com/pocopico/tcrp-addons/raw/main/boot-wait/rpext-index.json
./rploader.sh build ds918p-7.2.0-64561