Improve NotificationCenter speed and usability

[aleks-f]

Is your feature request related to a problem? Please describe. Currently, the NotificationCenter calls (N)Observer callback in the same thread where the subscribed-to event occurs. This slows down the event collection by executing the handling functionality "inline" in the event collection loop.

Additionally, notification dispatch in (N)Observer depends on dynamic_cast to determine whether to actually post the Notification to the Observer. The downside of this approach (aside from the dynamic_cast performance hit) is that it is not possible to distinguish observers by any other criteria except the compile-time notification type.

Describe the solution you'd like Decoupling event detection from handling would allow to collect event-generating data without being slowed down by the processing workload. Adding an additional (runtime) matching criteria would relax the current constraints and only actually interested observers could be determined prior to dynamic casting and calling the handler.

• NotificationCenter:
  • enqueueNotification()
• NObserver (all optional, * is only to describe what it conceptually is, could also be a unique_ptr):
  • dequeueNotification()
  • NotificationQueue*
  • Poco::Thread*
  • Dispatcher* (Runnable child)
  • (*match)(const Poco::Any&) callback

Describe alternatives you've considered Alternatively, this could be implemented as a separate pair of classes, inheriting from the existing ones (eg. ActiveNotificationCenter and ActiveObserver)

Additional context All this should be added as a default-off option, ie. without affecting the existing functionality. I'm inclined to deprecate the Poco::Observer in the future, eventually renaming NObserver to Observer with perhaps notifications being std::unique_ptr which are moved into the handlers.

[matejk]

NObserver and Observer shall definitely be merged into one implementation.

Is NotificationCenter::enqueueNotification() planned to be an enhanced postNotification() which does criteria matching?

Will a new thread be introduced that performs notification dispatching to registered observers to avoid the "inline" handling function?

[obiltschnig]

Rather than one class making do too much, I'd prefer a new class that does things differently, but in one specific way only.

[aleks-f]

Is NotificationCenter::enqueueNotification() planned to be an enhanced postNotification() which does criteria matching?

No, NotificationCenter should only enqueue notifications into a NotificationQueue.

Will a new thread be introduced that performs notification dispatching to registered observers to avoid the "inline" handling function?

Yes, there should be a "dequeuer", running in a thread, dequeuing notifications and notifying observers. Every observer should have two function pointers: bool match() and handle(), the latter called only if the former returns true.

Matching could be done through an Any parameter, or maybe it's better if we simply use the Notification::name() string.

The goals are to (1) decouple event posting from handling and (2) avoid notifying non-interested observers (currently, there is no way to indicate interest in just a subset of notifications of certain type - every subscriber to a Notification subtype gets all the notifications of that type, plus there's a dynamic_cast performance hit in Observer.

[aleks-f]

I made AsyncObserver child of NObserver. NotificationCenter remained (almost) intact.