search

pocoproject / poco

The POCO C++ Libraries are powerful cross-platform C++ libraries for building network- and internet-based applications that run on desktop, server, mobile, IoT, and embedded systems.
https://pocoproject.org
Other
8.05k stars 2.11k forks source link

2208 merge dnssd #4479

Closed aleks-f closed 3 months ago

aleks-f commented 4 months ago

replaces #4323

soroshsabz commented 4 months ago

ITNOA

@aleks-f Why close my PR?

What is your problem with my PR?

if you want to new PR, you can tell me to create new one

aleks-f commented 4 months ago

Because your pull did not trigger all CI.

I don't understand why does it matter who creates a pull request. But I do suggest to tread carefully - we expend quite a bit of resources on this project. Contributions are welcome, and we are thankful to anyone who is willing to help. But we have no obligation to accept contributions, and we especially do not have to tolerate being told how to accept them.

soroshsabz commented 4 months ago

@aleks-f

Ok, whatever way you see fit. :)

But if you want to merge my PR, I think, if you reopen #4323 and approve that, maybe PR can run CI.

soroshsabz commented 3 months ago

@aleks-f Is there anything I can do to help?

soroshsabz commented 3 months ago

you could not find any way to RUN CI on original PR?

soroshsabz commented 3 months ago

fixes #2208

soroshsabz commented 3 months ago

@aleks-f @matejk

Thanks a lot :)