search

podaac / concise

CONCISE (CONCatenatIon SErvice)
https://podaac.github.io/concise
Apache License 2.0
7 stars 4 forks source link

type mismatch and annotations #114

Open danielfromearth opened 4 months ago

danielfromearth commented 4 months ago

The input file type seems to expected to be pathlib.Path on this line where a .name attribute is accessed. However, this file path type is annotated as str at the beginning of the merge function, here.

I believe the annotation should be changed to say a Path needs to be inputted, or the input path str could be converted to a Path during execution. Which would be preferred? Or other suggestions?

jamesfwood commented 4 months ago

Hi @danielfromearth yeah I'd say go with the annotation to say Path needs to be inputted.

Also, we are going to make a release of this soon, so if you can update it then I can get it into the next release. Thanks!