podaac / cumulus-metadata-aggregator

1 stars 1 forks source link

PODAAC-5219 fixed NumberUtils.createInteger behavior which treats string with lea… #38

Closed yenes56 closed 1 year ago

yenes56 commented 1 year ago

Ticket: PODAAC-5219

Description

NumberUtils.createInteger(String s)

if s has leading zero, then NumberUtils will treat s as Octal format. this behavior is not what PODAAC expected. Hence, implemented an util function to remove leading zeros

Overview of work done

Implemented util function to remove leading zeros use the util function to remove leading zero before NumberUtils.createInteger Handle exception and change the MetadataAggregator to throw exception while cycle or pass are missing.

Overview of verification done

Tested in SIT:

N/A

PR checklist:

See Pull Request Review Checklist for pointers on reviewing this pull request

yenes56 commented 1 year ago

@skorper

Yes, this is the PR/branch deployed to swot-sit. I have addressed as much commented code as I could - so far. Could you please take another round of review? Thank you!