podaac / data-subscriber

Subscribe and bulk download collections of data at PO.DAAC
Apache License 2.0
83 stars 29 forks source link

added error messages for malformed and missing key in .harmony file to fix issue #168 #170

Closed avvalenx closed 5 months ago

avvalenx commented 5 months ago

Please let me know if any more information is needed

avvalenx commented 5 months ago

You're welcome @skorper! I added the changes to the unreleased section of the changelog. Please let me know if anything else is needed or if this was done incorrectly. Thank you.

skorper commented 5 months ago

@avvalenx Looks great, thank you! There is a conflict now, can you resolve that before I merge? Thanks again!

avvalenx commented 5 months ago

Yes conflict is resolved @skorper

avvalenx commented 5 months ago

@skorper what happened with these checks? Is this something I did wrong? I pulled from the main branch instead of development would that have an effect? Let me know if there is anything I can do to assist.

skorper commented 5 months ago

@avvalenx I think the build is failing because the secrets needed to run the regression tests are not present in your fork. I will go ahead and merge without the regression tests passing, since it's a simple enough change. Thanks again for your contribution!