Closed nikki-t closed 3 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
UAT modification required:
1) REST API Terraform definition require a small modification to ensure the Lambda authorizer keys are used, added api_key_source = "AUTHORIZER"
.
Confirmed via UAT benchmark tests:
1) That the trusted user usage plan will throttle requests to return a '429: Too Many Requests' error response. 2) That the trusted user usage plan will return a 'Limit Exceeded' error response when the request quota is met.
Looks good to me. Once we release to ops we should point out the accept-header information to the working group and ask them to utilize that functionality so that the output is compact by default (they may need to update their clients).
@frankinspace - I completely forgot about the Elastic heartbeat ping requests the gateway gets every 15 seconds. They are currently included in the default usage plan and (if my math is correct) would generate ~172,800 requests per month.
Should we stick with including them in the default plan or should we provide them with their own API key?
We decided to allow the ping requests to be a part of the default usage plan and will explore the necessity of providing a separate key and possible usage plan in issue #192.
[1.3.0]
Added
Changed
Deprecated
Removed
Fixed
Security
[1.2.0]
Added
Changed
Deprecated
Removed
Fixed
Security