podaac / hydrocron

API for retreiving time series of SWOT data
https://podaac.github.io/hydrocron/
Apache License 2.0
16 stars 4 forks source link

Create new API parameter for user to specify data version #233

Open torimcd opened 1 week ago

torimcd commented 1 week ago

Acceptance Criteria: User can indicate which data version they want results for. Hydrocron returns data belonging only to the collection version that is associated with the data version they indicated.

Some questions to discuss/confirm before starting:

What do we use as the data version indicator? Options that have been raised include:

What should the request parameter be? This depends on what we choose for the indicator

Should this parameter be required?

nikki-t commented 1 week ago

I like the idea of using collection_name as the query parameter with a value of collection shortname since users are used to working with collection shortnames doing Earthdata Search and CMR queries.

I also like the idea of keeping things simple and going with a data_version query parameter with a value of version letter or version number.

Thinking about the end user, how do they find this info (collection shortname or data version)? Which is easiest for them to find and/or more commonly used? Would it make sense to have both a version and a collection short name parameter?

I am inclined to not make this parameter required so that we do not introduce a breaking change but can be convinced that this is not a good idea! I think we should default to returning the Version C data until Version D data is available then we should default to Version D even though it may start out with only forward stream data. This way we can retire the version C data when appropriate and not impact the default.

We can document this decision for users so that they can figure out how to handle the switch. Either way we will need to broadcast the version change as it will require our end users to make some decisions on when to pull in the new version D data.