podaac / hydrocron

API for retreiving time series of SWOT data
https://podaac.github.io/hydrocron/
Apache License 2.0
17 stars 4 forks source link

granuleUR field can only be returned for reaches, fails for nodes and prior lakes #254

Open torimcd opened 1 month ago

torimcd commented 1 month ago

granuleUR is a valid output field for reaches: https://soto.podaac.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=Reach&feature_id=78340600051&output=geojson&start_time=2024-01-25T00:00:00Z&end_time=2024-03-29T00:00:00Z&fields=reach_id,time_str,wse,granuleUR,slope

but not for nodes: https://soto.podaac.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=Node&feature_id=12228200110861&start_time=2024-01-25T00:00:00Z&end_time=2024-03-30T00:00:00Z&output=geojson&fields=reach_id,node_id,time_str,granuleUR,wse

or for lakes: https://soto.podaac.earthdatacloud.nasa.gov/hydrocron/v1/timeseries?feature=PriorLake&feature_id=9120247642&start_time=2024-01-25T00:00:00Z&end_time=2025-10-20T00:00:00Z&output=geojson&fields=lake_id,time_str,granuleUR,wse

This may affect other fields as well, we should do check all the fields we expect to be able to return for all the feature types, and we should add a test to catch this.

torimcd commented 2 weeks ago

This might also be affecting the partial_f field for the node features. From @merrittharlan:I was wondering if partial_f is a valid output for the node data? It is listed as a possible variable in the Hydrocron timeseries documentation, but perhaps that flag is just for reach/lake data. When I try to include it in Hydrocron output, I get a response code 500.

nikki-t commented 1 week ago

Make sure constants are being used as expected and reflect all fields we want to support returning.