podaac / l2ss-py

Level 2 subsetter with Harmony integration
https://podaac.github.io/l2ss-py/
Apache License 2.0
11 stars 12 forks source link

Fix for Issue #93: Collection associations can be overwritten if made while release branch is opened #104

Closed Phoeneix closed 2 years ago

Phoeneix commented 2 years ago

Github Issue: #93

Overview of work done

Removed code from build pipeline that causes this issue.

Overview of verification done

Executed build

PR checklist:

See Pull Request Review Checklist for pointers on reviewing this pull request

Phoeneix commented 2 years ago

@skorper I removed that step, because it's only executed when the PR name contains "release" and targeting the main branch. It updates the cmr association with the local data, which was the cause of the related issue. If you think it should not be removed, I do not see any way to fix the related issue where an update on release happens and overwrites the data. If we expect that update on release, then the related issue is not an issue anymore but an expected behavior.

frankinspace commented 2 years ago

We need to be able to do both. We need to be able to update the umm-s record in UAT when there is a release branch open and we also need to be able to update cmr association data. What we want to avoid is if a new association happens while a release is open, merging the release should not discard that new association that was made.

Probably the easiest fix is a process change where the individual managing the release checks and makes sure no new associations were added during the time the release was open and if there were, to pull those in to the release before merging to master.

Phoeneix commented 2 years ago

@frankinspace If you can point out what counts as a newer association (higher version or other factors too?), then I can make changes to the updater to ignore those situations