search

podaac / l2ss-py

Level 2 subsetter with Harmony integration
https://podaac.github.io/l2ss-py/
Apache License 2.0
11 stars 11 forks source link

test notebook not running top-to-bottom #128

Open danielfromearth opened 1 year ago

danielfromearth commented 1 year ago

@ghayescrepps and I tried to run the test notebook, but had some issues getting it to run successfully. I'm not sure if some of it is just out-of-date. Please let me know if you'd like contributions to help update it. Here are the notes on what seems to have failed:

Issue 1

for x in urls:
    if x.get('Type') == "GET DATA" and x.get('Subtype') in [None, 'DIRECT DOWNLOAD'] and '.bin' not in x.get('URL'):
        granule_url = x.get('URL')

download_file(granule_url)

In the above code (in the "Download Original Granule" section), granule_url is set to the "s3" address rather than the "https" address for downloading. This is a TEMPO problem, because there are two download URLs defined with 'subtype=DIRECT DOWNLOAD'

Issue 2

In the "Get lon, lat, time variables" section, the notebook tries to call the function subset.get_coord_variable_names(ds). But it seems that the function is actually subset.get_coordinate_variable_names(ds).

Issue 3

In the "Get lon, lat, time variables" section, when the notebook calls the function subset.get_coordinate_variable_names() function, it is passed either a single group or the root-level group. L2SS is not able to find the latitude and longitude variables if they are not in that group.

Issue 4

In the "Get lon, lat, time variables" section, the notebook tries to call the function subset.get_time_variable_name(). But it seems that the function is actually subset.compute_time_variable_name().

Issue 5

group gets defined as the arbitrary last group, in the "Get lon, lat, time variables" section.