search

podaac / l2ss-py

Level 2 subsetter with Harmony integration
https://podaac.github.io/l2ss-py/
Apache License 2.0
11 stars 12 forks source link

re-add get timevar process for MLS #171

Closed nlenssen2013 closed 1 year ago

nlenssen2013 commented 1 year ago

Github Issue: #170

Description

Need to check the data variables if they equal to 'time' first then check the variables if time is in the var name. MLS was returning SolarLocalTime rather than just Time since SolarLocalTime is earlier in the sequence.

Overview of work done

Have two loops checking the variables prioritizing if 'time' == var_time_name

Overview of verification done

use MLS and OMI files with convert_to_datetime()

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

See Pull Request Review Checklist for pointers on reviewing this pull request

nlenssen2013 commented 1 year ago

Looks good! Only one comment: @nlenssen2013, could you just add a bit of explanation — either in line comments or in the docstring — for the sequence of checks... something along the lines of: first checking X, then checking Y, then we check if time equals, then we check if time is in the name. Just so its not too hard to decipher the logic when one looks at it again in the future.

Excellent suggestion, thank you