podaac / l2ss-py

Level 2 subsetter with Harmony integration
https://podaac.github.io/l2ss-py/
Apache License 2.0
11 stars 11 forks source link

Feature/issue 173 #174

Closed nlenssen2013 closed 1 year ago

nlenssen2013 commented 1 year ago

Github Issue: #173

Description

Spatial dimensions were being added to pressure variables thus the pressure variable was being bloated.

Overview of work done

Subset variables that have the dimensions in the indexers array in xarray_enhancements.py. Variables that do not have those dimensions should then be merged after xarray.where function applied.

Overview of verification done

Testing that the variable dimensions are the same going in as going out.

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

See Pull Request Review Checklist for pointers on reviewing this pull request

danielfromearth commented 1 year ago

Looks good!

jamesfwood commented 1 year ago

@nlenssen2013 @danielfromearth this will be deployed to UAT soon.