Feature/issue 194 - Githubissues

podaac / l2ss-py

Level 2 subsetter with Harmony integration

https://podaac.github.io/l2ss-py/

Apache License 2.0

11 stars 11 forks source link

Feature/issue 194 #195

Closed nlenssen2013 closed 11 months ago

nlenssen2013 commented 11 months ago

Github Issue: #194

Description

Variables requested in coordinate variables, that aren't a dimension to another variable are not included in output

Overview of work done

Change the variable subsetting in bbox to loop through all variables rather than just data variables

Overview of verification done

Test that the variable 'PRODUCT/corner' in S5P CH4 subset is returned when it is requested

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

[ x] Linted
[ x] Updated unit tests
[x] Updated changelog
[ ] Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

danielfromearth commented 11 months ago

@nlenssen2013, this looks good. I just made a few tweaks for readability & typing. The code's logic here is getting quite dense, so i'm just hoping to keep it as readable and manageable as possible.