search

podaac / l2ss-py

Level 2 subsetter with Harmony integration
https://podaac.github.io/l2ss-py/
Apache License 2.0
11 stars 11 forks source link

Feature/issue-205 #215

Closed nlenssen2013 closed 9 months ago

nlenssen2013 commented 9 months ago

Github Issue: #205 , #220

Description

If there are dimensions that have the same string name but different values in different groups. Then the xarray.rename_dims function will need to be used so that the copying variables back into the netCDF dataset is successfull

Overview of work done

get the names of dimensions that have different values and then put the old name and new name into the .rename_dims for an updated dataset. Check that the same time variable isn't added

Overview of verification done

run bounding box test on OMIPIXCOR data file

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

See Pull Request Review Checklist for pointers on reviewing this pull request

nlenssen2013 commented 9 months ago

Synk seems to be failing, and I'm not sure how to trouble shoot that

jamesfwood commented 9 months ago

@nlenssen2013 there are some conflicts that need fixing. Also, don't worry about the Synk and SonarCloud failure. I have another branch to address that. But if you can fix the conflicts then we should be able to merge this.

nlenssen2013 commented 9 months ago

@nlenssen2013 there are some conflicts that need fixing. Also, don't worry about the Synk and SonarCloud failure. I have another branch to address that. But if you can fix the conflicts then we should be able to merge this.

Conflicts are fixed. Added a small issue fix with the compute time coordinates function. Let me know if it's acceptable.