search

podaac / l2ss-py

Level 2 subsetter with Harmony integration
https://podaac.github.io/l2ss-py/
Apache License 2.0
11 stars 11 forks source link

Feature/fix null time values #231

Closed danielfromearth closed 5 months ago

danielfromearth commented 5 months ago

Github Issue: #227

Description

Avoid null values persisting on the ends of time variable array.

Overview of work done

Further improve the conditional indexing by preventing edge cases where the number of True values in the longest row does not encompass all indices along the missing dimension in which there are True values.

Overview of verification done

And ran the subsetter against local TEMPO test files, and then checking spatial+temporal bounds & visually inspecting maps:

TEMPO_CLDO4_L2_V01_20240123T232713Z_S013G05.nc
TEMPO_HCHO_L2_V01_20240110T170237Z_S005G08.nc
TEMPO_NO2_L2_V01_20240123T232713Z_S013G05.nc
TEMPO_O3TOT_L2_V01_20240123T232713Z_S013G05.nc

Overview of integration done

Added a new unit test, and ran the test suite.

PR checklist:

See Pull Request Review Checklist for pointers on reviewing this pull request

danielfromearth commented 5 months ago

@jamesfwood, I think this is ready to add to the release/2.8.0 and to then test in UAT.