search

podaac / l2ss-py

Level 2 subsetter with Harmony integration
https://podaac.github.io/l2ss-py/
Apache License 2.0
11 stars 11 forks source link

Accept a boolean from Harmony to set `cut=` parameter when run as part of service chain #247

Closed danielfromearth closed 2 months ago

danielfromearth commented 3 months ago

We've been tracking down a newly discovered bug that occurs when running the l2ss>Batchee>StitchEE>CONCISE chain in UAT.

It seems like the unexpected condition may have been hidden because of a discrepancy in arguments being passed to L2SS's high-level subset() function, between command-line invocations and Harmony invocations... cut=False by default in the cli; and no argument is given in the Harmony adapter so it uses the default of cut=True in the function definition.

In effect, I think l2-subsetter services have been (and probably want to continue) using cut=True, but for the batchee>stitchee>concise chain, we want cut=False.

It seems like to address this we might need a service- (or collection-) specific argument/configuration to be passed from Harmony to L2ss-py.

frankinspace commented 3 months ago

Previous discussions about this feature can be found in https://bugs.earthdata.nasa.gov/browse/PCESA-1528 https://bugs.earthdata.nasa.gov/browse/TRT-22 https://bugs.earthdata.nasa.gov/browse/TRT-13